Си — Говнокод.ру

Си / Говнокод #6646

+145

1
2
3
4
5
6
7
8

while ( strlen ( &ParseSMS[pos] ) != 0 )
{
    Byte0 = HexToByte(&ParseSMS[pos]);
    pos += 2;

    pSMS->sms[txt_counter] = Byte0;
    txt_counter ++;
}

достались исходнички. Человек не знает, как работает strlen
а буфер то на 140 байт !

megajohn, 13 Мая 2011

Комментарии (26)

Си / Говнокод #6636

+146

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49

char* a(int pos, char* path)
{ 
    FILE *dbf;
      char value; 
      int i,j,k,l,m,n,o,p,r;
      int numrecs, recnum; 
      Record rec;
      char aa[158];
      char *pp;
      int ln, lp, lc, le, lw, li, ls, lph, lf;    

      numrecs = rec.length; 
      recnum = pos;
    dbf = OpenDB(path, &rec);
    ReadRecord(dbf, recnum, &rec);    
    
        ln = strlen(rec.name);
        ls = strlen(rec.surname);
        lp = strlen(rec.patronymic);
        lph = strlen(rec.phone);
        lc = strlen(rec.city);
        le = strlen(rec.edu);
        lw = strlen(rec.work);
        li = strlen(rec.interests);
        lf = strlen(rec.friends);

        itoa(recnum, &(aa[0]), 10);
        for (i = 1; i < ln; i++)
            aa[i] = rec.name[i-1];
        for (j = 0; j < ls; j++)
            aa[i+j] = rec.surname[j];
        for (k = 0; k < lp; k++)
            aa[i+j+k] = rec.patronymic[k];
        for (l = 0; l < lph; l++)
            aa[i+j+k+l] = rec.phone[l];
        for (m = 0; m < lc; m++)
            aa[i+j+k+l+m] = rec.city[m];
        for (n = 0; n < le; n++)
            aa[i+j+k+l+m+n] = rec.edu[n];
        for (o = 0; o < lw; o++)
            aa[i+j+k+l+m+n+o] = rec.work[o];
        for (p = 0; p < li; p++)
            aa[i+j+k+l+m+n+o+p] = rec.interests[p];
        for (r = 0; r < lf; r++)
            aa[i+j+k+l+m+n+o+p+r] = rec.friends[r];

    pp = strdup(aa);  
    return pp;
}

dotnetdeveloper, 12 Мая 2011

Комментарии (20)

Си / Говнокод #6576

+137

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30

/***   First, attempting to establish a SSL-connection   ***/
		while(1)
		{
			sslConnection = sslConnect((const char *)remoteHost, port, CAFileName, CAPathName, error);
			if(!sslConnection)
			{
				logger(ERR, "receiver: Can not establish SSL connection with %s [description - %s]", remoteHost, error);
#ifndef DEBUG_MODE
				if (WaitForSingleObject (hExitEvent, 5000) == WAIT_OBJECT_0)
				{
					if(logLevel == DEBUG_LOG_LEVEL)
						logger(INFO, "receiver: Exit event was set in signaling state");
					logger(INFO, "receiver: Exit");
					return(0);
				}
#else
				Sleep(5000);
#endif
				continue;
			}
			else
			{
				if(logLevel == DEBUG_LOG_LEVEL)
				{
					logger(INFO, "receiver: Connection with %s is established", remoteHost);
				}
				socketError = 0;
				break;
			}
		}

Пытаемся подключиться к серверу по SSL/TLS, отваливаемся по событию

cepin, 06 Мая 2011

Комментарии (7)

Си / Говнокод #6543

+132

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32

static int
find_entry (int store, int entry, int *buffer)
  {
    int
	i,
	next;

    if ((entry <= 0) || (entry > Headers[store].size))
      {
	*buffer = EOL;
	return (ST_NOENTRY);
      }

    if (entry < (Headers[store].size/2))
      {
		/* search forwards through store */
		next = Headers[store].first;
		for (i=1; i<entry; i++)
			next = Buffers[next].next;
		*buffer = next;
      }
	  else
      {
		/* search backwards through store */
		next = Headers[store].last;
		for (i=Headers[store].size; i>entry; i--)
			next = Buffers[next].prev;
		*buffer = next;
      }

    return (SUCCESS);
  }

древний и заведомо рабочий код. а ищем-то что?

ilardm, 04 Мая 2011

Комментарии (12)

Си / Говнокод #6542

+139

1
2
3
4
5
6
7

const bool ejected = (device_type.is_new_protocol() ? device_status.status.stop : (!device_status.status.in_preset && !device_status.status.in_preset)) != 0;
...
if (  (p_ddevice && p_ddevice->preset_state.in_progress ())
   || (p_edevice && p_edevice->preset_state.in_progress ())
   )
   return (CTRL_WAIT);
...

я не повторяюсь никогда никогда

ilardm, 04 Мая 2011

Комментарии (57)

Си / Говнокод #6540

+102

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34

if (nchan == 1)
  {
    fprintf(commands_ptr,(char *)"StaNoise sta=%s start_time=%14.3f chan_list=%s window_type=nutall4a sub_window_length=%5.1f main_window_length=%6.1f out_dir=%s plot=yes record=yes decon=%s\n",sta,gmttime,chan_list[0],sub_window_length,main_window_length,out_dir,decon_c);
  }
  if (nchan == 2)
  {
    fprintf(commands_ptr,(char *)"StaNoise sta=%s start_time=%14.3f chan_list=%s,%s window_type=nutall4a sub_window_length=%5.1f main_window_length=%6.1f out_dir=%s plot=yes record=yes decon=%s\n",sta,gmttime,chan_list[0],chan_list[1],sub_window_length,main_window_length,out_dir,decon_c);
  }
  if (nchan == 3)
  {
    fprintf(commands_ptr,(char *)"StaNoise sta=%s start_time=%14.3f chan_list=%s,%s,%s window_type=nutall4a sub_window_length=%5.1f main_window_length=%6.1f out_dir=%s plot=yes record=yes decon=%s\n",sta,gmttime,chan_list[0],chan_list[1],chan_list[2],sub_window_length,main_window_length,out_dir,decon_c);
  }
  if (nchan == 4)
  {
    fprintf(commands_ptr,(char *)"StaNoise sta=%s start_time=%14.3f chan_list=%s,%s,%s,%s window_type=nutall4a sub_window_length=%5.1f main_window_length=%6.1f out_dir=%s plot=yes record=yes decon=%s\n",sta,gmttime,chan_list[0],chan_list[1],chan_list[2],chan_list[3],sub_window_length,main_window_length,out_dir,decon_c);
  }
  if (nchan == 5)
  {
    fprintf(commands_ptr,(char *)"StaNoise sta=%s start_time=%14.3f chan_list=%s,%s,%s,%s,%s window_type=nutall4a sub_window_length=%5.1f main_window_length=%6.1f out_dir=%s plot=yes record=yes decon=%s\n",sta,gmttime,chan_list[0],chan_list[1],chan_list[2],chan_list[3],chan_list[4],sub_window_length,main_window_length,out_dir,decon_c);
  }
  if (nchan == 6)
  {
    fprintf(commands_ptr,(char *)"StaNoise sta=%s start_time=%14.3f chan_list=%s,%s,%s,%s,%s,%s window_type=nutall4a sub_window_length=%5.1f main_window_length=%6.1f out_dir=%s plot=yes record=yes decon=%s\n",sta,gmttime,chan_list[0],chan_list[1],chan_list[2],chan_list[3],chan_list[4],chan_list[5],sub_window_length,main_window_length,out_dir,decon_c);
  }
  if (nchan == 7)
  {
    fprintf(commands_ptr,(char *)"StaNoise sta=%s start_time=%14.3f chan_list=%s,%s,%s,%s,%s,%s,%s window_type=nutall4a sub_window_length=%5.1f main_window_length=%6.1f out_dir=%s plot=yes record=yes decon=%s\n",sta,gmttime,chan_list[0],chan_list[1],chan_list[2],chan_list[3],chan_list[4],chan_list[5],chan_list[6],sub_window_length,main_window_length,out_dir,decon_c);
  }
...
  }
  if (nchan >= 14)
  {
    fprintf(commands_ptr,(char *)"StaNoise sta=%s start_time=%14.3f chan_list=%s,%s,%s,%s,%s,%s,%s,%s,%s,%s,%s,%s,%s,%s window_type=nutall4a sub_window_length=%5.1f main_window_length=%6.1f out_dir=%s plot=yes record=yes decon=%s\n",sta,gmttime,chan_list[0],chan_list[1],chan_list[2],chan_list[3],chan_list[4],chan_list[5],chan_list[6],chan_list[7],chan_list[8],chan_list[9],chan_list[10],chan_list[11],chan_list[12],chan_list[13],sub_window_length,main_window_length,out_dir,decon_c);
  }

Тяжело в сях работать со строками и переменным числом параметров...

Eyeless, 04 Мая 2011

Комментарии (17)

Си / Говнокод #6537

+140

1
2
3
4

if ((u[i]!=100500)&&(v[j]==100500))
    v[j]=matr[i+1][j+1].cost-u[i];
if ((u[i]==100500)&&(v[j]!=100500))
    u[i]=matr[i+1][j+1].cost-v[j];

пересчет платежей в ТЗЛП

resettik, 04 Мая 2011

Комментарии (5)

Си / Говнокод #6521

+130

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75

#include <stdio.h>
#include <signal.h>
#include <unistd.h>
#include <sys/wait.h>
void sighndlr_1(int signo) { //obrabot4ik dlya 1go processa
    printf("I'm child process #1. I've got SIGINT! :) So, I won't do anything...\n"); //prosto vyvod na ekran soobscheniya o polu4enii signala
}

void sighndlr_2(int signo) { //dlhya 2go
    printf("I'm child process #2. I've got SIGINT :)\n");
}

int main(int argc, char **argv) {
    pid_t pid1,pid2,pid3,pid4; //4 do4ernih processa
    static struct sigaction act1,act2,act3; //3 struktury dlya 3h processov
    act1.sa_handler = sighndlr_1; //ustanovka obrabot4ika dlya 1 struktory
    act2.sa_handler = sighndlr_2; //dlya 2i
    act3.sa_handler = SIG_IGN; //ignoriruem signal v 3 strukture
    switch(pid1 = fork()) { //sozdaem 1 do4erniy process
    case -1: //vihodim pri oshibke sozdaniya
	printf("Error fork\n");
	exit(1);
	break;
    case 0:
	printf("Child process #1 started (pid = %d)\n", getpid()); //soobshenie ob uspeshnom sozdanii i vyvod pid
	sigaction(SIGINT,&act1,NULL); //ustanovka struktury obrabot4ika dlya SIGINT
	for(;;) pause(); //beskone4nyi cikl
	break;
    default:
    switch(pid2 = fork()) { //sozdaem 2 process
    case -1:
	printf("Error fork\n");
	exit(1);
	break;
    case 0:
	printf("Child process #2 started (pid = %d)\n", getpid());
	sigaction(SIGINT,&act2,NULL); //dlya SIGINT
	sigaction(SIGQUIT,&act3,NULL); //ignorim SIGQUIT
	for(;;) pause();
	break;
    default:
    switch(pid3 = fork()) { //3 process
    case -1:
	printf("Error fork\n");
	exit(1);
	break;
    case 0:
	printf("Child process #3 started (pid = %d)\n", getpid());
	sigaction(SIGINT,&act3,NULL); //ignorim SIGINT
	for(;;) pause();
	break;
    default:
    switch(pid4 = fork()) { //4 process
    case -1:
	printf("Error fork\n");
	exit(1);
	break;
    case 0:
	printf("Child process #4 started (pid = %d)\n", getpid());
	setsid(); //menyaem identifikator seansa dlya processa
	printf("Process #4 changed sid\n");
	for(;;) pause();
	break;
    default:
    printf("Finishing parent process... (pid = %d)\n", getpid());
    exit(0); //zavershaetsya roditelsky process
    break;
    }        
    break;
    }
    break;
    }
    break;
    }
}

Лаба по курсу операционных систем. Нужно было создать 4 дочерних процесса, и для каждого процесса создать свои обработчики для сигнала SIGINT или SIGQUIT. Полученный говнокод полон повторяющихся конструкций, и слишком сильно запутан операторами switch-case.

Boten, 30 Апреля 2011

Комментарии (36)

Говнокод: по колено в коде.