- 1
- 2
- 3
- 4
public void setDoubleValue( double doubleValue ) {
DecimalFormat myFormatter = new DecimalFormat("###.##");
this.doubleValue=Double.valueOf(myFormatter.format(doubleValue));
}
Нашли или выдавили из себя код, который нельзя назвать нормальным, на который без улыбки не взглянешь? Не торопитесь его удалять или рефакторить, — запостите его на говнокод.ру, посмеёмся вместе!
+62.9
public void setDoubleValue( double doubleValue ) {
DecimalFormat myFormatter = new DecimalFormat("###.##");
this.doubleValue=Double.valueOf(myFormatter.format(doubleValue));
}
Округление дробной части до двух знаков запятой? Даже если так, то как насчет статического члена класса?
+130.3
void View1(){
SaveResult1();
}
+122.1
while (true)
{
try
{ b = img.ReadByte(); }
catch (EndOfStreamException ex)
{
break;
}
ba[pos] = b;
pos++;
}
Таким образом читают потоки, пользователи anti-captcha.com
В первый раз увидел, ппц))))))
−218
for ($i=1;$i++;$i<=$r) {
print qq~</div>~;
}
Перепутал местами...
−255.6
sub player_win{
my $self = shift;
my ($T, $U) = @_;
my $H = $self->file_to_hash($T);
my $WIN = 0;
my ($i, $k, $c, $z) = (0, 0, 0, 0);
if( $T->{_MAX_COUNT} == 32 ){
for($i = 0; $i < 2; $i++){
for($k = 0; $k < 2; $k++){
for($c = 0; $c < 2; $c++){
for($z = 0; $z < 2; $z++){
foreach(0..1){
if($H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[$k]->{f8}[$c]->{f16}[$z]->{ppl}[$_]->{id} == $U->{_ID}){
if($H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[$k]->{f8}[$c]->{f16}[$z]->{id} == 0){
$H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[$k]->{f8}[$c]->{f16}[$z]->{id} = $U->{_ID};
$WIN = $H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[$k]->{f8}[$c]->{f16}[0]->{id} if $z == 1;
$WIN = $H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[$k]->{f8}[$c]->{f16}[1]->{id} if $z == 0;
} elsif($H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[$k]->{f8}[$c]->{id} == 0){
$H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[$k]->{f8}[$c]->{id} = $U->{_ID};
$WIN = $H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[$k]->{f8}[0]->{id} if $c == 1;
$WIN = $H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[$k]->{f8}[1]->{id} if $c == 0;
} elsif ($H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[$k]->{id} == 0){
$H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[$k]->{id} = $U->{_ID};
$WIN = $H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[0]->{id} if $k == 1;
$WIN = $H->{data}->{grid}->{f1}->{f2}[$i]->{f4}[1]->{id} if $k == 0;
} elsif ($H->{data}->{grid}->{f1}->{f2}[$i]->{id} == 0){
$H->{data}->{grid}->{f1}->{f2}[$i]->{id} = $U->{_ID};
$WIN = $H->{data}->{grid}->{f1}->{f2}[0]->{id} if $i == 1;
$WIN = $H->{data}->{grid}->{f1}->{f2}[1]->{id} if $i == 0;
} elsif ($H->{data}->{grid}->{f1}->{id} == 0){
$H->{data}->{grid}->{f1}->{id} = $U->{_ID};
$WIN = -1;
}
}
}
}
}
}
}
} elsif( $T->{_MAX_COUNT} == 16 ){
for($i = 0; $i < 2; $i++){
for($k = 0; $k < 2; $k++){
for($c = 0; $c < 2; $c++){
foreach(0..1){
if($H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[$k]->{f8}[$i]->{ppl}[$_]->{id} == $U->{_ID}){
if($H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[$k]->{f8}[$i]->{id} == 0){
$H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[$k]->{f8}[$i]->{id} = $U->{_ID};
$WIN = $H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[$k]->{f8}[0]->{id} if $i == 1;
$WIN = $H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[$k]->{f8}[1]->{id} if $i == 0;
} elsif ($H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[$k]->{id} == 0){
$H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[$k]->{id} = $U->{_ID};
$WIN = $H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[0]->{id} if $k == 1;
$WIN = $H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[1]->{id} if $k == 0;
} elsif ($H->{data}->{grid}->{f1}->{f2}[$c]->{id} == 0){
$H->{data}->{grid}->{f1}->{f2}[$c]->{id} = $U->{_ID};
$WIN = $H->{data}->{grid}->{f1}->{f2}[0]->{id} if $c == 1;
$WIN = $H->{data}->{grid}->{f1}->{f2}[1]->{id} if $c == 0;
} elsif ($H->{data}->{grid}->{f1}->{id} == 0){
$H->{data}->{grid}->{f1}->{id} = $U->{_ID};
$WIN = -1;
}
}
}
}
}
}
} elsif($T->{_MAX_COUNT} == 8){
for($k = 0; $k < 2; $k++){
for($c = 0; $c < 2; $c++){
foreach(0..1){
if($H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[$k]->{ppl}[$_]->{id} == $U->{_ID}){
if($H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[$k]->{id} == 0){
$H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[$k]->{id} = $U->{_ID};
$WIN = $H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[0]->{id} if $k == 1;
$WIN = $H->{data}->{grid}->{f1}->{f2}[$c]->{f4}[1]->{id} if $k == 0;
} elsif ($H->{data}->{grid}->{f1}->{f2}[$c]->{id} == 0){
$H->{data}->{grid}->{f1}->{f2}[$c]->{id} = $U->{_ID};
$WIN = $H->{data}->{grid}->{f1}->{f2}[0]->{id} if $c == 1;
$WIN = $H->{data}->{grid}->{f1}->{f2}[1]->{id} if $c == 0;
} elsif ($H->{data}->{grid}->{f1}->{id} == 0){
$H->{data}->{grid}->{f1}->{id} = $U->{_ID};
$WIN = -1;
}
}
}
}
}
} elsif($T->{_MAX_COUNT} == 4){
for($c = 0; $c < 2; $c++){
foreach(0..1){
if($H->{data}->{grid}->{f1}->{f2}[$c]->{ppl}[$_]->{id} == $U->{_ID}){
if($H->{data}->{grid}->{f1}->{f2}[$c]->{id} == 0){
$H->{data}->{grid}->{f1}->{f2}[$c]->{id} = $U->{_ID};
$WIN = $H->{data}->{grid}->{f1}->{f2}[0]->{id} if $c == 1;
$WIN = $H->{data}->{grid}->{f1}->{f2}[1]->{id} if $c == 0;
} elsif ($H->{data}->{grid}->{f1}->{id} == 0){
$H->{data}->{grid}->{f1}->{id} = $U->{_ID};
$WIN = -1;
}
}
Очень "гибкий" алгоритм.
−305.1
my ($_bonus1_l, $_bonus1_y, $_bonus2_l, $_bonus2_y) = ($l1*10 > rand(100) ? 1 : 0, $y1*10 > rand(100) ? 1 : 0, $l2*10 > rand(100) ? 1 : 0, $y2*10 > rand(100) ? 1 : 0);
($_bonus1_l, $_bonus2_l) = (0, 0) if $_bonus1_l == 1 and $_bonus2_l == 1;
($_bonus1_y, $_bonus2_y) = (0, 0) if $_bonus1_y == 1 and $_bonus2_y == 1;
if($turn > 12){
my ($_a1_def, $_b1_def, $_c1_def) = mass($pl1_mov, $User1, "def");
my ($_a1_att, $_b1_att, $_c1_att) = mass($pl1_att, $User1, "att");
my ($_a2_def, $_b2_def, $_c2_def) = mass($pl2_mov, $User2, "def");
my ($_a2_att, $_b2_att, $_c2_att) = mass($pl2_att, $User2, "att");
$N1 += $_a1_att if $_a2_def < 1000000;
$N1 += $_b1_att if $_b2_def < 1000000;
$N1 += $_c1_att if $_c2_def < 1000000;
$N2 += $_a2_att if $_a1_def < 1000000;
$N2 += $_b2_att if $_b1_def < 1000000;
$N2 += $_c2_att if $_c1_def < 1000000;
if($_bonus1_l){
my $l = int(rand(3));
## сБНПНР
if($l == 0){
my $r = 0;
($_a2_att, $r) = (0, 1) if $_a2_att > 0 and $_a1_def < 1000000;
($_b2_att, $r) = (0, 1) if $_b2_att > 0 and $_a1_def < 1000000 and $r == 0;
($_c2_att, $r) = (0, 1) if $_c2_att > 0 and $_a1_def < 1000000 and $r == 0;
$U1 = $r;
} elsif($l == 1){
my $r = 0;
($_a1_att, $r, $K2) = (int($_a1_att * 1.5), 1, int($_a1_att/2)) if $_a1_att > 0 and $_a2_def < 1000000;
($_b1_att, $r, $K2) = (int($_b1_att * 1.5), 1, int($_b1_att/2)) if $_b1_att > 0 and $_b2_def < 1000000 and $r == 0;
($_c1_att, $r, $K2) = (int($_c1_att * 1.5), 1, int($_c1_att/2)) if $_c1_att > 0 and $_c2_def < 1000000 and $r == 0;
} elsif($l == 2){
my ($r, $ov, $v) = (0, 0, int(rand(3)));
($_a1_att, $r, $ov) = (0, 1, (int($_a2_att/2))) if $_a2_att > 0 and $_a1_def > 1000000;
($_b1_att, $r, $ov) = (0, 1, (int($_b2_att/2))) if $_b2_att > 0 and $_b1_def > 1000000 and $r == 0;
($_c1_att, $r, $ov) = (0, 1, (int($_c2_att/2))) if $_c2_att > 0 and $_c1_def > 1000000 and $r == 0;
$_a1_att += $ov if $v == 0;
$_b1_att += $ov if $v == 1;
$_c1_att += $ov if $v == 2;
$O1 = $ov;
}
}
if($_bonus2_l){
my $l = int(rand(100));
if($l == 0){
my $r = 0;
($_a1_att, $r) = (0, 1) if $_a1_att > 0 and $_a2_def < 1000000;
($_b1_att, $r) = (0, 1) if $_b1_att > 0 and $_a2_def < 1000000 and $r == 0;
($_c1_att, $r) = (0, 1) if $_c1_att > 0 and $_a2_def < 1000000 and $r == 0;
$U2 = $r;
} elsif($l == 1){
my $r = 0;
($_a2_att, $r, $K1) = (int($_a2_att * 1.5), 1, int($_a2_att/2)) if $_a2_att > 0 and $_a1_def < 1000000;
($_b2_att, $r, $K1) = (int($_b2_att * 1.5), 1, int($_b2_att/2)) if $_b2_att > 0 and $_b1_def < 1000000 and $r == 0;
($_c2_att, $r, $K1) = (int($_c2_att * 1.5), 1, int($_c2_att/2)) if $_c2_att > 0 and $_c1_def < 1000000 and $r == 0;
} elsif($l == 2){
my ($r, $ov, $v) = (0, 0, int(rand(3)));
($_a2_att, $r, $ov) = (0, 1, (int($_a1_att/2))) if $_a1_att > 0 and $_a2_def > 1000000;
($_b2_att, $r, $ov) = (0, 1, (int($_b1_att/2))) if $_b1_att > 0 and $_b2_def > 1000000 and $r == 0;
($_c2_att, $r, $ov) = (0, 1, (int($_c1_att/2))) if $_c1_att > 0 and $_c2_def > 1000000 and $r == 0;
$_a2_att += $ov if $v == 0;
$_b2_att += $ov if $v == 1;
$_c2_att += $ov if $v == 2;
$O2 = $ov;
}
}
if($_bonus1_y){
my $l = int(rand(2));
if($l == 0){
my ($r, $rik, $V1) = (0, 0, int(rand(3)) + 1);
($r, $rik) = (1, (int($_a1_att/2))) if $_a1_att > 0 and $_a2_def < 1000000 and $V1 == 1;
($r, $rik) = (1, (int($_b1_att/2))) if $_b1_att > 0 and $_b2_def < 1000000 and $r == 0 and $V1 == 2;
($r, $rik) = (1, (int($_c1_att/2))) if $_c1_att > 0 and $_c2_def < 1000000 and $r == 0 and $V1 == 3;
$R2 = $rik;
$db->query("UPDATE duel set pl1_rik = CONCAT(pl1_rik, $V1) where sid = \"$dsid\"") if $R2 > 0;
} elsif($l == 1){
my $r = 0;
($_a2_def, $r) = ($_a2_def - 1000000, 1) if $_a1_att > 0 and $_a2_def > 1000000;
($_b2_def, $r) = ($_b2_def - 1000000, 2) if $_b1_att > 0 and $_b2_def > 1000000 and $r == 0;
($_c2_def, $r) = ($_c2_def - 1000000, 3) if $_c1_att > 0 and $_c2_def > 1000000 and $r == 0;
$T2 = $r;
}
}
if($_bonus2_y){
my $l = int(rand(2));
if($l == 0){
my ($r, $rik, $V2) = (0, 0, int(rand(3)) + 1);
($r, $rik) = (1, (int($_a2_att/2))) if $_a2_att > 0 and $_a1_def < 1000000 and $V2 == 1;
($r, $rik) = (1, (int($_b2_att/2))) if $_b2_att > 0 and $_b1_def < 1000000 and $r == 0 and $V2 == 2;
($r, $rik) = (1, (int($_c2_att/2))) if $_c2_att > 0 and $_c1_def < 1000000 and $r == 0 and $V2 == 3;
#$_a2_att += $rik if $V2 == 1;
#$_b2_att += $rik if $V2 == 2;
#$_c2_att += $rik if $V2 == 3;
$R1 = $rik;
$db->query("UPDATE duel set pl2_rik = CONCAT(pl2_rik, $V2) where sid = \"$dsid\"") if $R1 > 0;
} elsif($l == 1){
my $r = 0;
($_a1_def, $r) = ($_a1_def - 1000000, 1) if $_a2_att > 0 and $_a1_def > 1000000;
($_b1_def, $r) = ($_b1_def - 1000000, 2) if $_b2_att > 0 and $_b1_def > 1000000 and $r == 0;
Из браузерной игрушки на mod_perl/mysql. Код наглядно демонстрирует, что говнокод зависит не от языка, а от программиста.
+167.2
if (!!Flag === true)
{
...
}
−307.7
sub get_ppl{
my $self = shift;
my ($U, $print_done, $team) = @_;
return "<ppl team_id='$team' battle_stats='$U->{_CHAR}->{win},$U->{_CHAR}->{loose},$U->{_CHAR}->{nobody}' medals='".$U->get_medal_string_for_user($U)."' $clan team_id='0' av_id='$U->{_CHAR}->{av_id}' fn='$U->{_CHAR}->{avatara}' u='$U->{_CHAR}->{u}' hp_u='$U->{_CHAR}->{hp_u}' stat0_u='$U->{_CHAR}->{stat0_u}' stat0='$U->{_CHAR}->{f}' stat1='$U->{_CHAR}->{m}' stat2='$U->{_CHAR}->{y}' stat3='$U->{_CHAR}->{l}' hpmax='$U->{_CHAR}->{maxhp}' hp='$U->{_CHAR}->{hp}' aname='$U->{_USER_NAME}' lvl='$U->{_CHAR}->{lvl}' cname='$U->{_CHAR}->{name}' id='$U->{_ID}' carma='$U->{_CHAR}->{carma}' sex='$U->{_CHAR}->{sex}' slot0='$Item[0]' slot8='$Item[8]' slot7='$Item[7]' slot6='$Item[6]' slot1='$Item[1]' weight='$U->{_CHAR}->{weight}' slot5='$Item[5]' slot4='$Item[4]' slot3='$Item[3]' slot2='$Item[2]' city_id='$U->{_CHAR}->{city_id}'/>" if !$print_done;
return "<ppl done='true' battle_stats='$U->{_CHAR}->{win},$U->{_CHAR}->{loose},$U->{_CHAR}->{nobody}' medals='".$U->get_medal_string_for_user($U)."' $clan team_id='0' av_id='$U->{_CHAR}->{av_id}' fn='$U->{_CHAR}->{avatara}' u='$U->{_CHAR}->{u}' hp_u='$U->{_CHAR}->{hp_u}' stat0_u='$U->{_CHAR}->{stat0_u}' stat0='$U->{_CHAR}->{f}' stat1='$U->{_CHAR}->{m}' stat2='$U->{_CHAR}->{y}' stat3='$U->{_CHAR}->{l}' hpmax='$U->{_CHAR}->{maxhp}' hp='$U->{_CHAR}->{hp}' aname='$U->{_USER_NAME}' lvl='$U->{_CHAR}->{lvl}' cname='$U->{_CHAR}->{name}' id='$U->{_ID}' carma='$U->{_CHAR}->{carma}' sex='$U->{_CHAR}->{sex}' slot0='$Item[0]' slot8='$Item[8]' slot7='$Item[7]' slot6='$Item[6]' slot1='$Item[1]' weight='$U->{_CHAR}->{weight}' slot5='$Item[5]' slot4='$Item[4]' slot3='$Item[3]' slot2='$Item[2]' city_id='$U->{_CHAR}->{city_id}'/>" if $print_done;
}
Забавная проверка
−868
CREATE OR REPLACE VIEW my_schema.my_view AS
SELECT
TO_NUMBER (c.payment_term_code) ID,
c.payment_term_code sap_code, c.payment_term_name longname,
c.short_name shortname, c.comment_line comments, c.cust_relevant, c.vend_relevant, c.active active,
c.updated_by created_by, c.updated_by updated_by, c.updated_on created_on, c.updated_on updated_on, 1 txn_ver
FROM my_schema.my_table c
WHERE ( LENGTH (c.payment_term_code) = 1
AND SUBSTR (c.payment_term_code, 1, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
)
OR ( LENGTH (c.payment_term_code) = 2
AND SUBSTR (c.payment_term_code, 1, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
AND SUBSTR (c.payment_term_code, 2, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
)
OR ( LENGTH (c.payment_term_code) = 3
AND SUBSTR (c.payment_term_code, 1, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
AND SUBSTR (c.payment_term_code, 2, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
AND SUBSTR (c.payment_term_code, 3, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
)
OR ( LENGTH (c.payment_term_code) = 4
AND SUBSTR (c.payment_term_code, 1, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
AND SUBSTR (c.payment_term_code, 2, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
AND SUBSTR (c.payment_term_code, 3, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
AND SUBSTR (c.payment_term_code, 4, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
)
OR ( LENGTH (c.payment_term_code) = 5
AND SUBSTR (c.payment_term_code, 1, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
AND SUBSTR (c.payment_term_code, 2, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
AND SUBSTR (c.payment_term_code, 3, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
AND SUBSTR (c.payment_term_code, 4, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
AND SUBSTR (c.payment_term_code, 5, 1) IN ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')
)
UNION
SELECT ID, sap_code, longname, shortname, comments, 'Y', 'Y', active, created_by, updated_by, created_on, updated_on, 1
FROM my_schema.my_other_table) tt
Вот так в 30 строк пиндосы защищаются от проникновения буковков в TO_NUMBER()
−870.8
select
--
(case
when (sum(distinct sub.est_cost) - sum(distinct sub.act_cost)) > 0 then
(sum(distinct sub.est_cost) - sum(distinct sub.act_cost))
when (sum(distinct sub.est_cost) - sum(distinct sub.act_cost)) < 0 then
(sum(distinct sub.est_cost) - sum(distinct sub.act_cost))
else
0
end)
--
from blablabla
Не пускайте бразильских футболистов к компьютеру!