Говнокод: по колено в коде.

• Все
• Лучший
• Сток
• Глупый поиск
• Наговнокодить!
• Oтзывы

Нашли или выдавили из себя код, который нельзя назвать нормальным, на который без улыбки не взглянешь? Не торопитесь его удалять или рефакторить, — запостите его на говнокод.ру, посмеёмся вместе!

1. PHP (5703)
2. C++ (2740)
3. Куча (2337)
4. JavaScript (2030)
5. C# (1929)
6. Java (1503)
7. Си (1103)
8. Pascal (649)
9. Python (585)
10. 1C (536)
11. SQL (434)
12. ActionScript (294)
13. Objective C (204)
14. bash (200)
15. Perl (196)
16. Assembler (148)
17. Ruby (144)
18. VisualBasic (140)
19. Lua (51)
20. Go (32)
21. Swift (29)
22. Haskell (28)
23. Kotlin (15)

1. SQL / Говнокод #6148

   −862

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24

   BEGIN
       DECLARE @id_user int;
       IF (EXISTS(SELECT ut.id_user FROM project_userTable ut WHERE ut.userStr=@UserName OR ut.email = @email))
           begin
               SET @errors='Такое имя или пароль уже существуют';
               RETURN;
           end
       INSERT INTO project_userTable (userStr,passwordStr,email,profileLink,id_user_type,activate_ticket)
       VALUES (@UserName,@password, @email, @profileLink,2,@activate_ticket)
       IF (@@ROWCOUNT!=1)
       begin
           SET @errors='Ошибка регистрации';
           RETURN
       end
       SET @id_user=@@IDENTITY;
       INSERT INTO project_keyTable ([datetime],id_user, first_key ,second_key )
       VALUES (GETDATE(),@id_user,@firstKey,@secodKey)
       IF (@@ROWCOUNT=1)
       begin
           SET @errors='Done';
           RETURN
       end
       SET @errors='А воттеперь реально косяк.';
   END

   Реально косяк. Кстати, а что читать?

   akaDElpher, 30 Марта 2011

   Комментарии (2)

2. SQL / Говнокод #6111

   −862

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13

   SET @SQL = '
         SELECT 
           @diff1 = @diff1 + ''CASE WHEN '' + Field_Name + ''=@'' + Field_Name + 
           '' OR ('' + Field_Name + '' IS null AND @'' + Field_Name + '' IS NULL) THEN ''''''''
     ELSE '''''' + Field_Name + ''="''''+COALESCE(CAST('' + Field_Name + '' AS varchar(max)), ''''NULL'''') 
     + ''''", '''' END +'', 
           @diff2 = @diff2 + ''CASE WHEN '' + Field_Name + ''=@'' + Field_Name + 
           '' OR ('' + Field_Name + '' IS Null AND @'' + Field_Name + '' IS NULL) THEN ''''''''
     ELSE '''''' + Field_Name + ''="''''+COALESCE(CAST(@'' + Field_Name + '' AS varchar(max)), ''''NULL'''')
     + ''''", '''' END +'', 
           @declare = @declare + ''DECLARE @'' + Field_Name +  '' '' + Field_Type + '';'',
           @set = @set + ''SET @'' + Field_Name + ''='' + Field_Value + '';''
           FROM (' + @pre + ') AS t'

   Моё. Кусочек небольшой хранимки в 700 строк.
   
   Формирование SQL-a, который формирует SQL, который, в свою очередь, формирует строку для записи изменений таблицы в лог.

   alter_reserved, 29 Марта 2011

   Комментарии (8)

3. SQL / Говнокод #6105

   −862

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20

   -- Verify frequency sub-day type
     IF (@freq_subday_type <> 0) AND (@freq_subday_type NOT IN (0x1, 0x2, 0x4, 0x8))
     BEGIN
       RAISERROR(14266, -1, -1, '@freq_subday_type', '0x1, 0x2, 0x4, 0x8')
       RETURN(1) -- Failure
     END
   ....
   
    IF (@freq_subday_type = 0)
       SELECT @freq_subday_type = 0x1 -- FREQSUBTYPE_ONCE
   
     IF ((@freq_subday_type <> 0x1) AND  -- FREQSUBTYPE_ONCE   (see qsched.h)
         (@freq_subday_type <> 0x2) AND  -- FREQSUBTYPE_SECOND (see qsched.h)
         (@freq_subday_type <> 0x4) AND  -- FREQSUBTYPE_MINUTE (see qsched.h)
         (@freq_subday_type <> 0x8))     -- FREQSUBTYPE_HOUR   (see qsched.h)
     BEGIN
       SELECT @reason = FORMATMESSAGE(14266, '@freq_subday_type', '0x1, 0x2, 0x4, 0x8')
       RAISERROR(14278, -1, -1, @reason)
       RETURN(1) -- Failure
     END

   Системная хранимая процедура Microsoft SQL Server 2005
   msdb.[dbo].[sp_verify_schedule]

   alter_reserved, 28 Марта 2011

   Комментарии (0)

4. SQL / Говнокод #6084

   −863

   1. 1
   2. 2
   3. 3

   WHERE (p.city_id = 1)
      AND ((COALESCE(b.banket_persons,0)=0) OR (b.banket_persons>=20 AND b.banket_persons<=30))
      AND ((COALESCE(b.banket_per_person,0)=0) OR (b.banket_per_person>=500 AND b.banket_per_person<=1000))

   упорный программер явно не подозревал о существовании "is null" и "between"

   NaCilnic, 24 Марта 2011

   Комментарии (5)

5. SQL / Говнокод #6074

   −860

   1. 1
   2. 2
   3. 3
   4. 4

   update dv_main set dv_main.tp_id = 2 where dv_main.uid in
   (SELECT dv.uid FROM (select * from dv_main) as dv
   LEFT JOIN users u ON (u.uid = dv.uid)
   WHERE dv.tp_id = 1);

   Вот так вот саппорт одного биллинга посоветовал массово сменить тарифный план пользователям...

   NiTr0man, 23 Марта 2011

   Комментарии (3)

6. SQL / Говнокод #6065

   −855

   1. 1
   2. 2

   $order_by="`name` ASC";
       echo mysql_result(mysql_query("SELECT CONCAT('<ul><li>',GROUP_CONCAT(CONCAT('<a href=',`parents`.`id`,'>',`parents`.`name`,'</a>', IFNULL(`children`.`a`,'')) ORDER BY $order_by SEPARATOR '</li><li>'),'</li><ul>') FROM (SELECT `id`,`name` FROM `cats` WHERE `parent_id`=0) parents LEFT JOIN (SELECT `id`, CONCAT('<ul><li>',GROUP_CONCAT(CONCAT('<a href=',`id`,'>',`name`,'</a>') ORDER BY $order_by SEPARATOR '</li><li>'),'</li></ul>') a, `parent_id` FROM cats GROUP BY `parent_id` HAVING `parent_id`<>0) children ON `parents`.`id`=`children`.`parent_id` ;",$cn),0);

   Выборка категорий и подкатегорий, рабочая ссылка
   http://fradvice.com/test.php

   thefatfox, 22 Марта 2011

   Комментарии (3)

7. SQL / Говнокод #6000

   −170

   1. 1

   SELECT 6000 FROM GETS

   qbasic, 16 Марта 2011

   Комментарии (14)

8. SQL / Говнокод #5979

   −851

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24
   25. 25
   26. 26
   27. 27
   28. 28
   29. 29
   30. 30
   31. 31
   32. 32
   33. 33
   34. 34

   select distinct bk.ID, bk.URL, bk.Date, bk.Name, bk.Description, bk.UserCreatorID from bookmarking_bookmark as bk 
   where bk.Tenant=@Tenant and bk.ID in 
   (select *  from (select b.ID  from bookmarking_bookmark as b  left join  bookmarking_bookmarktag as bt on b.ID=bt.BookmarkID left join bookmarking_tag as t  on bt.TagID=t.TagID 
   left join (select ub.BookmarkID as BookmarkID, ub.Name as UserBookmarkName,ub.Description as UserBookmarkDescription, t.Name as TagName  
   from (select * from bookmarking_userbookmark as ub where ub.UserID=@userID) as ub 
   left join bookmarking_userbookmarktag as ubt  on ub.UserBookmarkID=ubt.UserBookmarkID  
   left join bookmarking_tag as t  on ubt.TagID=t.TagID) as ub on b.ID=ub.BookmarkID 
   where  ( ( lower(b.URL) like lower(@tagNameForUrlWithoutLastSlash0) )  
   or (lower(b.Name) like lower(@tagName0) or lower(b.Name) like lower(@tagNameWithSpace0)) 
   or (lower(b.Description) like lower(@tagName0) or lower(b.Description) like lower(@tagNameWithSpace0))    
   or (lower(t.Name) like lower(@tagName0)) or (lower(t.Name)  like lower(@tagNameWithSpace0)) 
   or (lower(TagName) like lower(@tagName0)) or (lower(TagName) like lower(@tagNameWithSpace0))    
   or (lower(UserBookmarkName) like lower(@tagName0) or lower(UserBookmarkName) like lower(@tagNameWithSpace0))    
   or (lower(UserBookmarkDescription) like lower(@tagName0) or lower(UserBookmarkDescription) like lower(@tagNameWithSpace0)))  
   and b.ID in (
   select b.ID   from bookmarking_bookmark as b  left join  bookmarking_bookmarktag as bt  on b.ID=bt.BookmarkID
   left join bookmarking_tag as t    on bt.TagID=t.TagID 
   left join  (
   select ub.BookmarkID as BookmarkID, ub.Name as UserBookmarkName, ub.Description as UserBookmarkDescription, t.Name as TagName from 
   (select * from bookmarking_userbookmark as ub where ub.UserID=@userID) as ub  
   left join bookmarking_userbookmarktag as ubt on ub.UserBookmarkID=ubt.UserBookmarkID
   left join bookmarking_tag as t on ubt.TagID=t.TagID) as ub on b.ID=ub.BookmarkID
   where  (( lower(b.URL) like lower(@tagNameForUrlWithoutLastSlash1) ) or (lower(b.Name) like lower(@tagName1) or lower(b.Name) like lower(@tagNameWithSpace1)) 
   or (lower(b.Description) like lower(@tagName1) or lower(b.Description) like lower(@tagNameWithSpace1)) or (lower(t.Name) like lower(@tagName1)) 
   or (lower(t.Name)  like lower(@tagNameWithSpace1)) or (lower(TagName) like lower(@tagName1)) or (lower(TagName) like lower(@tagNameWithSpace1))  
   or (lower(UserBookmarkName) like lower(@tagName1) or lower(UserBookmarkName) like lower(@tagNameWithSpace1)) or (lower(UserBookmarkDescription)
   like lower(@tagName1) or lower(UserBookmarkDescription) like lower(@tagNameWithSpace1))) and b.ID in (
   select b.ID from bookmarking_bookmark as b left join bookmarking_bookmarktag as bt on b.ID=bt.BookmarkID left join bookmarking_tag as t on bt.TagID=t.TagID left join
   (select ub.BookmarkID as BookmarkID, ub.Name as UserBookmarkName,  ub.Description as UserBookmarkDescription, t.Name as TagName 
   from (select * from bookmarking_userbookmark as ub where ub.UserID=@userID) as ub 
   left join bookmarking_userbookmarktag as ubt on ub.UserBookmarkID=ubt.UserBookmarkID  left join bookmarking_tag as t on ubt.TagID=t.TagID) as ub on b.ID=ub.BookmarkID
   where (( lower(b.URL) like lower(@tagNameForUrlWithoutLastSlash2) ) or (lower(b.Name) like lower(@tagName2) or lower(b.Name) like lower(@tagNameWithSpace2))
   or (lower(b.Description) like lower(@tagName2) or lower(b.Description) like lower(@tagNameWithSpace2)) or (lower(t.Name) like lower(@tagName2)) or (lower(t.Name)
   like lower(@tagNameWithSpace2)) or....

   среднее время выполнения 30 секунд

   arusanov, 14 Марта 2011

   Комментарии (115)

9. SQL / Говнокод #5978

   −864

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24
   25. 25
   26. 26
   27. 27
   28. 28
   29. 29
   30. 30
   31. 31
   32. 32
   33. 33
   34. 34
   35. 35
   36. 36
   37. 37
   38. 38
   39. 39

   SELECT foo.oper_id,
   	                     foo.client_id,
   			     base_clients.name,
   			     base_clients.options,
   			     base_providers.name,
   	  		     base_subproviders.name,
   			     base_clients.address_post,
   			     base_clients.balance,
   			     base_currency_types.descr,
   			     base_clients.descr,
   			     base_clients.client_type,
   			     base_clients.pdn_permission_taken,
   			     base_clients.person_use_srv_as_org,
   	             base_clients.none_client
   		      FROM   (SELECT oper_id,client_id FROM base_clients WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )   AND ( base_clients.client_id = '681843' OR base_clients.personal_id = '681843' OR base_clients.name ~ '[66][88][11][88][44][33]' OR base_clients.address_post ILIKE  '%681843%'OR base_clients.descr ILIKE '%681843%' )  UNION SELECT DISTINCT oper_id,client_id FROM telephone_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM channel_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM dry_pair_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM inet_dynamic_ip_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   
   				UNION 
   				    SELECT DISTINCT sss.oper_id, sss.client_id 
   					FROM inet_fixed_ip_services as sss
   					    left join inet_fixed_ip_group_items as itms on (sss.oper_id = itms.oper_id and sss.user_id = itms.ip_group )
   				    WHERE 
   					 (  sss.oper_id = 'TT'  OR sss.oper_id = 'SC'  OR sss.oper_id = 'TT2'  OR sss.oper_id = 'RC'  )  AND 
   					(  
   					    sss.user_id ILIKE '%681843%'  
   						OR
   					    itms.ip ILIKE '%681843%'  
   					)
   			     UNION SELECT DISTINCT oper_id,client_id FROM unix_shell_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM voip_ip_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM voip_card_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM ani_phone_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM cable_tv_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'  UNION select distinct oper_id,client_id from base_client_aon_list where caller_phone = '681843' AND  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  ) AS foo 
   		             JOIN 
   			     base_clients ON foo.oper_id=base_clients.oper_id AND 
   			                     foo.client_id=base_clients.client_id 
   			     JOIN 
   			     base_providers ON base_clients.oper_id=base_providers.oper_id 
   			     JOIN 
   			     base_currency_types ON base_clients.oper_id=base_currency_types.oper_id AND 
   			                            base_clients.currency_type=base_currency_types.currency_type
   	                     LEFT JOIN
   			     base_subproviders ON base_clients.oper_id=base_subproviders.oper_id AND
   	                                          base_clients.suboper_id=base_subproviders.suboper_id 
   	              ORDER BY to_number(base_clients.client_id,'999999999') DESC

   Это запрос на простой поиск клиента в биллинге.

   spaceoflabview, 14 Марта 2011

   Комментарии (3)

10. SQL / Говнокод #5944

    −862

    1. 01
    2. 02
    3. 03
    4. 04
    5. 05
    6. 06
    7. 07
    8. 08
    9. 09
    10. 10
    11. 11
    12. 12
    13. 13
    14. 14
    15. 15
    16. 16
    17. 17
    18. 18

    select
    PTS.*,
    (select client_type_id from clients where client_id = PTS.client_id) as client_type_id,
    (select name ||''|| address from ats_list
    where id = PTS.ats_id) as ats_name,
    
    (select name ||''|| ip_address from dslam_list
    where id = PTS.dslam_id) as dslam_name,
    
    (select label from point_statuses_view
    where code = PTS.statuscross) as statuscross,
    
    (select typename from asrtypes
    where typename_value = '1' and typename_id = PTS.country_id) as country_name
    
    from points as PTS
    where
    PTS.point_id = 118749

    Ни про LEFT JOIN ни про ORM похоже автор не слышал.

    nyk0r, 10 Марта 2011

    Комментарии (0)

• ← влево
• вправо →

• 44
• …
• 23
• 22
• 21
• 20
• 19
• 18
• 17
• 16
• 15
• …
• 1