Говнокод: по колено в коде.

• Все
• Лучший
• Сток
• Глупый поиск
• Наговнокодить!
• Oтзывы

Нашли или выдавили из себя код, который нельзя назвать нормальным, на который без улыбки не взглянешь? Не торопитесь его удалять или рефакторить, — запостите его на говнокод.ру, посмеёмся вместе!

1. PHP (5706)
2. C++ (2739)
3. Куча (2371)
4. JavaScript (2030)
5. C# (1928)
6. Java (1502)
7. Си (1117)
8. Pascal (648)
9. Python (586)
10. 1C (539)
11. SQL (432)
12. ActionScript (292)
13. Objective C (202)
14. bash (198)
15. Perl (194)
16. Assembler (146)
17. Ruby (145)
18. VisualBasic (138)
19. Lua (49)
20. Go (31)
21. Haskell (29)
22. Swift (27)
23. Kotlin (14)

1. Java / Говнокод #12539

   +115

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19

   try {
   	// Store settings in the database as a JSON string
   	machine.setSettings(CustomJacksonRepresentation.createCanonicalObjectMapper().writeValueAsString(
   			request.getSettings()));
   } catch (final JsonMappingException e) {
   	// We obtained request by parsing JSON in the first place,
   	// no way it can fail to be serialized back o_O
   	throw new AssertionError(e);
   } catch (final JsonGenerationException e) {
   	// See above
   	throw new AssertionError(e);
   } catch (final IOException e) {
   	// Why does writeValueAsString throw IOException anyway? How CAN you fail to write to a String?
   	// Seriously, what were the writers of Jackson smoking that they exposed IOException in the API
   	// in a method specifically designed to serialize to String, just because the underlying implementation
   	// uses StringWriter (which doesn't really throw IOException anyway)?
   	// I mean, I understand if the string is too long to fit in memory, but that's an OutOfMemoryError
   	throw new AssertionError(e);
   }

   someone, 05 Февраля 2013

   Комментарии (1)

2. JavaScript / Говнокод #12538

   +148

   1. 1

   document.getElementById('siF20').disabled=(this.checked==true)?false:true;

   kasthack, 05 Февраля 2013

   Комментарии (4)

3. C# / Говнокод #12537

   +137

   1. 1
   2. 2
   3. 3
   4. 4
   5. 5
   6. 6
   7. 7
   8. 8

   SqlConnection connection = new SqlConnection(connectionString);
               SqlCommand command = connection.CreateCommand();
               using (connection = new SqlConnection(connectionString))
               {
                   command.CommandText = storedProcedure;
               }
   
               command.Connection.Open();

   Открывает соединение с сервером.

   kore_sar, 05 Февраля 2013

   Комментарии (3)

4. C# / Говнокод #12536

   +103

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13

   private static bool IsSourceField(DataRow row, string fieldName)
           {
               try
               {
                   object fieldValue = row[fieldName];
   
                   return false;
               }
               catch
               {
                   return false;
               }
           }

   Бизнес логика.

   kore_sar, 05 Февраля 2013

   Комментарии (20)

5. JavaScript / Говнокод #12535

   +183

   1. 1

   while (c.charAt(0)==' ') c = c.substring(1,c.length);

   Особый ltrim

   3.14159265, 04 Февраля 2013

   Комментарии (44)

6. Си / Говнокод #12534

   +111

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24
   25. 25
   26. 26
   27. 27
   28. 28
   29. 29
   30. 30
   31. 31
   32. 32
   33. 33
   34. 34
   35. 35
   36. 36
   37. 37
   38. 38
   39. 39
   40. 40

   /* ..от молодых, дерзких и успешных,
   форматирование и комментарии сохранены. */
   void zanulit_massiv ()
   {
   	int i;
   	for(i=0;i<27;i++) // dlja vseh elementov massiva
   	{
   		switch (i)   // perebiraem
   		{
   		case 0: mass_znach[0]=3;
   		case 1: mass_znach[0]=5;
   		case 2: mass_znach[0]=6;
   		case 3: mass_znach[0]=1;
   		case 4: mass_znach[0]=2;
   		case 5: mass_znach[0]=3;
   		case 6: mass_znach[0]=4;
   		case 7: mass_znach[0]=5;
   		case 8: mass_znach[0]=6;
   		case 9: mass_znach[0]=31;
   		case 10: mass_znach[0]=2;
   		case 11: mass_znach[0]=1;
   		case 12: mass_znach[0]=1;
   		case 13: mass_znach[0]=1;
   		case 14: mass_znach[0]=33;
   		case 15: mass_znach[0]=15;
   		case 16: mass_znach[0]=13;
   		case 17: mass_znach[0]=8;
   		case 18: mass_znach[0]=43;
   		case 19: mass_znach[0]=2;
   		case 20: mass_znach[0]=9;
   		case 21: mass_znach[0]=14;
   		case 22: mass_znach[0]=17;
   		case 23: mass_znach[0]=21;
   		case 24: mass_znach[0]=22;
   		case 25: mass_znach[0]=8;
   		case 26: mass_znach[0]=5;
   		default: break; // objazatelno v sluchae neizvesnogo znacheniya
   		}
   	}
   }

   Не могу больше :|

   neudachnik, 03 Февраля 2013

   Комментарии (35)

7. Си / Говнокод #12533

   +139

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24
   25. 25
   26. 26

   for( i=0; i<MAX_CHANNELS; i++ )
     {
       ht->ht_Voices[i].vc_Delta=1;
       ht->ht_Voices[i].vc_OverrideTranspose=1000;  // 1.5
       ht->ht_Voices[i].vc_SamplePos=ht->ht_Voices[i].vc_Track=ht->ht_Voices[i].vc_Transpose=ht->ht_Voices[i].vc_NextTrack = ht->ht_Voices[i].vc_NextTranspose = 0;
       ht->ht_Voices[i].vc_ADSRVolume=ht->ht_Voices[i].vc_InstrPeriod=ht->ht_Voices[i].vc_TrackPeriod=ht->ht_Voices[i].vc_VibratoPeriod=ht->ht_Voices[i].vc_NoteMaxVolume=ht->ht_Voices[i].vc_PerfSubVolume=ht->ht_Voices[i].vc_TrackMasterVolume=0;
       ht->ht_Voices[i].vc_NewWaveform=ht->ht_Voices[i].vc_Waveform=ht->ht_Voices[i].vc_PlantSquare=ht->ht_Voices[i].vc_PlantPeriod=ht->ht_Voices[i].vc_IgnoreSquare=0;
       ht->ht_Voices[i].vc_TrackOn=ht->ht_Voices[i].vc_FixedNote=ht->ht_Voices[i].vc_VolumeSlideUp=ht->ht_Voices[i].vc_VolumeSlideDown=ht->ht_Voices[i].vc_HardCut=ht->ht_Voices[i].vc_HardCutRelease=ht->ht_Voices[i].vc_HardCutReleaseF=0;
       ht->ht_Voices[i].vc_PeriodSlideSpeed=ht->ht_Voices[i].vc_PeriodSlidePeriod=ht->ht_Voices[i].vc_PeriodSlideLimit=ht->ht_Voices[i].vc_PeriodSlideOn=ht->ht_Voices[i].vc_PeriodSlideWithLimit=0;
       ht->ht_Voices[i].vc_PeriodPerfSlideSpeed=ht->ht_Voices[i].vc_PeriodPerfSlidePeriod=ht->ht_Voices[i].vc_PeriodPerfSlideOn=ht->ht_Voices[i].vc_VibratoDelay=ht->ht_Voices[i].vc_VibratoCurrent=ht->ht_Voices[i].vc_VibratoDepth=ht->ht_Voices[i].vc_VibratoSpeed=0;
       ht->ht_Voices[i].vc_SquareOn=ht->ht_Voices[i].vc_SquareInit=ht->ht_Voices[i].vc_SquareLowerLimit=ht->ht_Voices[i].vc_SquareUpperLimit=ht->ht_Voices[i].vc_SquarePos=ht->ht_Voices[i].vc_SquareSign=ht->ht_Voices[i].vc_SquareSlidingIn=ht->ht_Voices[i].vc_SquareReverse=0;
       ht->ht_Voices[i].vc_FilterOn=ht->ht_Voices[i].vc_FilterInit=ht->ht_Voices[i].vc_FilterLowerLimit=ht->ht_Voices[i].vc_FilterUpperLimit=ht->ht_Voices[i].vc_FilterPos=ht->ht_Voices[i].vc_FilterSign=ht->ht_Voices[i].vc_FilterSpeed=ht->ht_Voices[i].vc_FilterSlidingIn=ht->ht_Voices[i].vc_IgnoreFilter=0;
       ht->ht_Voices[i].vc_PerfCurrent=ht->ht_Voices[i].vc_PerfSpeed=ht->ht_Voices[i].vc_WaveLength=ht->ht_Voices[i].vc_NoteDelayOn=ht->ht_Voices[i].vc_NoteCutOn=0;
       ht->ht_Voices[i].vc_AudioPeriod=ht->ht_Voices[i].vc_AudioVolume=ht->ht_Voices[i].vc_VoiceVolume=ht->ht_Voices[i].vc_VoicePeriod=ht->ht_Voices[i].vc_VoiceNum=ht->ht_Voices[i].vc_WNRandom=0;
       ht->ht_Voices[i].vc_SquareWait=ht->ht_Voices[i].vc_FilterWait=ht->ht_Voices[i].vc_PerfWait=ht->ht_Voices[i].vc_NoteDelayWait=ht->ht_Voices[i].vc_NoteCutWait=0;
       ht->ht_Voices[i].vc_PerfList=0;
       ht->ht_Voices[i].vc_RingSamplePos=ht->ht_Voices[i].vc_RingDelta=ht->ht_Voices[i].vc_RingPlantPeriod=ht->ht_Voices[i].vc_RingAudioPeriod=ht->ht_Voices[i].vc_RingNewWaveform=ht->ht_Voices[i].vc_RingWaveform=ht->ht_Voices[i].vc_RingFixedPeriod=ht->ht_Voices[i].vc_RingBasePeriod=0;
   
       ht->ht_Voices[i].vc_RingMixSource = NULL;
       ht->ht_Voices[i].vc_RingAudioSource = NULL;
   
       memset(&ht->ht_Voices[i].vc_SquareTempBuffer,0,0x80);
       memset(&ht->ht_Voices[i].vc_ADSR,0,sizeof(struct hvl_envelope));
       memset(&ht->ht_Voices[i].vc_VoiceBuffer,0,0x281);
       memset(&ht->ht_Voices[i].vc_RingVoiceBuffer,0,0x281);
     }

   Щито оно делает?

   Govnocoder#0xFF, 03 Февраля 2013

   Комментарии (12)

8. PHP / Говнокод #12532

   +79

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24
   25. 25
   26. 26
   27. 27
   28. 28
   29. 29
   30. 30
   31. 31
   32. 32
   33. 33
   34. 34
   35. 35
   36. 36
   37. 37
   38. 38
   39. 39
   40. 40
   41. 41
   42. 42
   43. 43
   44. 44
   45. 45
   46. 46
   47. 47
   48. 48
   49. 49
   50. 50
   51. 51
   52. 52
   53. 53
   54. 54
   55. 55
   56. 56
   57. 57

   if ($foto1 != "") {
                                           $fotourl = $foto1;
                                   } else {
                                           if ($foto2 != "") {
                                                   $fotourl = $foto2;
                                           } else {
                                                   if ($foto3 != "") {
                                                           $fotourl = $foto3;
                                                   } else {
                                                           if ($foto4 != "") {
                                                                   $fotourl = $foto4;
                                                           } else {
                                                                   if ($foto5 != "") {
                                                                           $fotourl = $foto5;
                                                                   } else {
                                                                           if ($foto6 != "") {
                                                                                   $fotourl = $foto6;
                                                                           } else {
                                                                                   if ($foto7 != "") {
                                                                                           $fotourl = $foto7;
                                                                                   } else {
                                                                                           if ($foto8 != "") {
                                                                                                   $fotourl = $foto8;
                                                                                           } else {
                                                                                                   if ($foto9 != "") {
                                                                                                           $fotourl = $foto9;
                                                                                                   } else {
                                                                                                           if ($foto10 != "") {
                                                                                                                   $fotourl = $foto10;
                                                                                                           } else {
                                                                                                                   if ($foto11 != "") {
                                                                                                                           $fotourl = $foto11;
                                                                                                                   } else {
                                                                                                                           if ($foto12 != "") {
                                                                                                                                   $fotourl = $foto12;
                                                                                                                           } else {
                                                                                                                                   if ($foto13 != "") {
                                                                                                                                           $fotourl = $foto13;
                                                                                                                                   } else {
                                                                                                                                           if ($foto14 != "") {
                                                                                                                                                   $fotourl = $foto14;
                                                                                                                                           } else {
                                                                                                                                                    // продолжение 
                                                                                                                                           }
                                                                                                                                   }
                                                                                                                           }
                                                                                                                   }
                                                                                                           }
                                                                                                   }
                                                                                           }
                                                                                   }
                                                                           }
                                                                   }
                                                           }
                                                   }
                                           }
                                   }

   Дали допилить сайт

   uadeveloper, 03 Февраля 2013

   Комментарии (22)

9. C# / Говнокод #12531

   +140

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24
   25. 25
   26. 26
   27. 27
   28. 28
   29. 29
   30. 30
   31. 31
   32. 32
   33. 33
   34. 34
   35. 35
   36. 36
   37. 37
   38. 38
   39. 39
   40. 40
   41. 41

   <%@ Page Language="C#" AutoEventWireup="true" CodeBehind="user_task_list.aspx.cs" Inherits="prototype_alpha.user_task_list" %>
       <form id="user_task_list_form" action="user_task_list.aspx" method="post">
           <div>
               <p>Поданные заказы</p>
               <%foreach (LABA_OP_SITE.Task item in TaskList.Where(a => a.TaskState == 101 || a.TaskState == 102))
                 {
                     var q = BidList.Where(a => a.TaskID == item.TaskID);%>
               <%=TaskDataList.Where(a=>a.TaskID==item.TaskID).First().TaskTitle + " | " + q.Count() + " | " +item.TaskPutDate + " | "+ item.TaskDeadline + " | average bid(fuck up) | "+CommentList.Where(a=>a.TaskID==item.TaskID && a.CommentRead==0).Count()%>
               <br />
               <% }%>
               <p>task title* || bids' count* || task put date* || task work end date* || average bid || new comments*</p>
               <p>Выполняемые заказы</p>
               <%foreach (LABA_OP_SITE.Task item in TaskList.Where(a => a.TaskState >= 0 || a.TaskState < 100))
                 {
               <%=TaskDataList.Where(a=>a.TaskID==item.TaskID).First().TaskTitle + " | task start date | task work end date(time span) |"+item.TaskState+BidList.Where(a=>a.BidID==item.BidID).First().Bid1+" | "+CommentList.Where(a=>a.TaskID==item.TaskID && a.CommentRead==0).Count()%>
               <br />
               <% }%>
               <p>task title* || task start date || task work end date(time span) || state* || price* || new comments*</p>
               <p>Выполненные(не сданы) заказы</p>
               <%foreach (LABA_OP_SITE.Task item in TaskList.Where(a => a.TaskState == 100))
                 {
               <%=TaskDataList.Where(a=>a.TaskID==item.TaskID).First().TaskTitle + " | task start date | "+item.TaskWorkCompleteDate+" | "+BidList.Where(a=>a.BidID==item.BidID).First().Bid1+" | "+CommentList.Where(a=>a.TaskID==item.TaskID && a.CommentRead==0).Count()%>
               <br />
               <% }%>
               <p>task title* || task start date || task work end date(saw into)* || price* || new comments*</p>
               <p>Выполненные(сданы) заказы</p>
               <%foreach (LABA_OP_SITE.Task item in TaskList.Where(a => a.TaskState == 103 || a.TaskState == 104))
                 {
               <%=TaskDataList.Where(a=>a.TaskID==item.TaskID).First().TaskTitle + " | task start date | "+item.TaskWorkCompleteDate+" | "+BidList.Where(a=>a.BidID==item.BidID).First().Bid1%>
               <br />
               <% }%>
               <p>task title* || task start date || task work end date(saw into)* || price*</p>
               <p>Замороженные заказы</p>
               <%foreach (LABA_OP_SITE.Task item in TaskList.Where(a => a.TaskState <0))
                 {
               <%=TaskDataList.Where(a=>a.TaskID==item.TaskID).First().TaskTitle + " | task start date | "+item.TaskDeadline+" | "+BidList.Where(a=>a.BidID==item.BidID).First().Bid1%>
               <br />
               <% }%>
               <p>task title* || task start date || task work end date(deadline)* || price*</p>
           </div>
       </form>

   От человека требовалось написать написать отладочную страницу для списка заказов.
   
   *TaskList, TaskDataList, CommentList, BidList - массивы

   kasthack, 03 Февраля 2013

   Комментарии (9)

10. Java / Говнокод #12530

    +63

    1. 1
    2. 2
    3. 3
    4. 4
    5. 5
    6. 6
    7. 7
    8. 8
    9. 9

    int i = (int)Math.pow(10, (n - 1)); 
              int max = i*5;
              int count = 0;
                
              for (i = i; i < max; i++) {  // i = i ??              
                 if (isUnique(i, i*2, n)) { 
                    count++;
                    System.out.printf("%s %s \n", i, i*2);
                 }

    Как обойтись без такого кулхацкерного самоприсваивания?

    Govnocoder#0xFF, 02 Февраля 2013

    Комментарии (8)

• ← влево
• вправо →

• 2107
• …
• 1130
• 1129
• 1128
• 1127
• 1126
• 1125
• 1124
• 1123
• 1122
• …
• 1