По колено в коде — Говнокод.ру

C# / Говнокод #11231

+134

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15

public static DataSet GetSomeDataSet()
{
    DataSet ds = null;
    object locker = new object();
    lock (locker)
    {
        if (ds == null)
        {
            // тут инициализация ds

            return ds;
        }
        else return ds;
    }
}

Метод из работающей проги. Возпроизвёл по памяти, но суть именно такая.
Насколько понимаю, человек хотел результаты работы метода кэшировать в локальную переменную.
Да ещё и lock на локальную переменную, который никогда не используется.

Ordos, 19 Июня 2012

Комментарии (10)

Java / Говнокод #11230

+78

01
02
03
04
05
06
07
08
09
10
11
12
13

String result = "";

for (Object obj : col) {
    if (obj instanceof String) {
        result += obj + SEPARATOR;
    } else {
        result += obj.toString() + SEPARATOR;
    }
}
					
if (result.length() >= 2) {
    result = result.substring(0, result.length() - SEPARATOR.length());
}

instanceof String доставил.
Кстати, к проекту подключены apache.commons.lang и guava, так что способов сделать join строк предостаточно.

roman-kashitsyn, 19 Июня 2012

Комментарии (102)

ActionScript / Говнокод #11229

−167

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22

public function getFiltersDescription () : IList
{
	var model : ITableBasedModuleModel = this.getTableBasedModel();
	return model.filtersDescription;
}

public function getModuleTitle () : String
{
	var model : ITableBasedModuleModel = this.getTableBasedModel();
	return model.getTitle();
}

//....
private function getTableBasedModel () : ITableBasedModuleModel
{
	return this.model as ITableBasedModuleModel;
}

private function getTableBasedView () : ITableBasedModuleView
{
	return this.view as ITableBasedModuleView;
}

Java ооп головного мозга.

kyzi007, 19 Июня 2012

Комментарии (8)

Pascal / Говнокод #11228

+110

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60

if (M[1]<>M[2]) and (M[1]<>M[3]) and (M[1]<>M[4]) and (M[1]<>M[5]) and (M[1]<>M[6]) then
begin
if (M[1]<>M[7]) and (M[1]<>M[8]) and (M[1]<>M[9]) and (M[1]<>M[10]) then
write('  ',M[1],'  ');
end;
 
if (M[2]<>M[1]) and (M[2]<>M[3]) and (M[2]<>M[4]) and (M[2]<>M[5]) and (M[2]<>M[6]) then
begin
if (M[2]<>M[7]) and (M[2]<>M[8]) and (M[2]<>M[9]) and (M[2]<>M[10]) then
write('  ',M[2],'  ');
end;
 
if (M[3]<>M[1]) and (M[3]<>M[2]) and (M[3]<>M[4]) and (M[3]<>M[5]) and (M[3]<>M[6]) then
begin
if (M[3]<>M[7]) and (M[3]<>M[8]) and (M[3]<>M[9]) and (M[3]<>M[10]) then
write('  ',M[3],'  ');
end;
 
if (M[4]<>M[1]) and (M[4]<>M[2]) and (M[4]<>M[3]) and (M[4]<>M[5]) and (M[4]<>M[6]) then
begin
if (M[4]<>M[7]) and (M[4]<>M[8]) and (M[4]<>M[9]) and (M[4]<>M[10]) then
write('  ',M[4],'  ');
end;
 
if (M[5]<>M[1]) and (M[5]<>M[2]) and (M[5]<>M[3]) and (M[5]<>M[4]) and (M[5]<>M[6]) then
begin
if (M[5]<>M[7]) and (M[5]<>M[8]) and (M[5]<>M[9]) and (M[5]<>M[10]) then
write('  ',M[5],'  ');
end;
 
if (M[6]<>M[1]) and (M[6]<>M[2]) and (M[6]<>M[3]) and (M[6]<>M[4]) and (M[6]<>M[5]) then
begin
if (M[6]<>M[7]) and (M[6]<>M[8]) and (M[6]<>M[9]) and (M[6]<>M[10]) then
write('  ',M[6],'  ');
end;
 
if (M[7]<>M[1]) and (M[7]<>M[2]) and (M[7]<>M[3]) and (M[7]<>M[4]) and (M[7]<>M[5]) then
begin
if (M[7]<>M[6]) and (M[7]<>M[8]) and (M[7]<>M[9]) and (M[7]<>M[10]) then
write('  ',M[7],'  ');
end;
readln;
 
if (M[8]<>M[1]) and (M[8]<>M[2]) and (M[8]<>M[3]) and (M[8]<>M[4]) and (M[8]<>M[5]) then
begin
if (M[8]<>M[6]) and (M[8]<>M[7]) and (M[8]<>M[9]) and (M[8]<>M[10]) then
write('  ',M[8],'  ');
end;
 
if (M[9]<>M[1]) and (M[9]<>M[2]) and (M[9]<>M[3]) and (M[9]<>M[4]) and (M[9]<>M[5]) then
begin
if (M[9]<>M[6]) and (M[9]<>M[7]) and (M[9]<>M[8]) and (M[8]<>M[10]) then
write('  ',M[9],'  ');
end;
 
if (M[10]<>M[1]) and (M[10]<>M[2]) and (M[10]<>M[3]) and (M[10]<>M[4]) and (M[10]<>M[5]) then
begin
if (M[10]<>M[6]) and (M[10]<>M[7]) and (M[10]<>M[8]) and (M[10]<>M[9]) then
write('  ',M[10],'  ');
end;

Циклы? Не, не слышал...

HighPredator, 19 Июня 2012

Комментарии (6)

C++ / Говнокод #11227

−30

1

TTime childStartTime(TDateTime(2006, EJanuary, 8, 14, 0, 0, 0)); // January 9th 2pm

Из примера calexample в symbian sdk.

bormand, 19 Июня 2012

Комментарии (14)

PHP / Говнокод #11226

+142

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19

<?php

	switch(1==1) {
	
		case true;
		
			// ...
		
		break;
		
		case false;
			
			// ...
			
		break;
	
	}

?>

Аналог конструкции if-else...

killro0000, 18 Июня 2012

Комментарии (7)

Куча / Говнокод #-11225

+28

1

<br />

striker, 18 Июня 2012

Комментарии (211)

PHP / Говнокод #11224

+65

1

$needDied = $this->battle_data['type'] == 104 ? true : false;

AndryG, 18 Июня 2012

Комментарии (7)

SQL / Говнокод #11177

−153

1
2
3
4
5
6

SELECT count(*) as cnt FROM cms_books AS b  	
	JOIN (SELECT DISTINCT r.book_id FROM cms_book2cat AS r
	JOIN (SELECT 40 AS category_id 
		UNION SELECT 105 AS category_id UNION SELECT 212 AS category_id UNION SELECT 404 AS category_id UNION SELECT 1 AS category_id UNION SELECT 2 AS category_id UNION SELECT 3 AS category_id UNION SELECT 5 AS category_id UNION SELECT 62 AS category_id UNION SELECT 60 AS category_id UNION SELECT 59 AS category_id UNION SELECT 58 AS category_id UNION SELECT 55 AS category_id UNION SELECT 54 AS category_id UNION SELECT 51 AS category_id UNION SELECT 50 AS category_id UNION SELECT 49 AS category_id UNION SELECT 71 AS category_id UNION SELECT 72 AS category_id UNION SELECT 78 AS category_id UNION SELECT 85 AS category_id UNION SELECT 86 AS category_id UNION SELECT 90 AS category_id UNION SELECT 91 AS category_id UNION SELECT 92 AS category_id UNION SELECT 94 AS category_id UNION SELECT 96 AS category_id UNION SELECT 101 AS category_id UNION SELECT 156 AS category_id UNION SELECT 157 AS category_id UNION SELECT 222 AS category_id UNION SELECT 226 AS category_id UNION SELECT 398 AS category_id UNION SELECT 406 AS category_id UNION SELECT 407 AS category_id UNION SELECT 416 AS category_id UNION SELECT 417 AS category_id UNION SELECT 890 AS category_id UNION SELECT 106 AS category_id UNION SELECT 108 AS category_id UNION SELECT 111 AS category_id UNION SELECT 115 AS category_id UNION SELECT 152 AS category_id UNION SELECT 121 AS category_id UNION SELECT 125 AS category_id UNION SELECT 159 AS category_id UNION SELECT 195 AS category_id UNION SELECT 257 AS category_id UNION SELECT 262 AS category_id UNION SELECT 302 AS category_id UNION SELECT 306 AS category_id UNION SELECT 397 AS category_id UNION SELECT 401 AS category_id UNION SELECT 402 AS category_id UNION SELECT 403 AS category_id UNION SELECT 413 AS category_id UNION SELECT 414 AS category_id UNION SELECT 213 AS category_id UNION SELECT 214 AS category_id UNION SELECT 215 AS category_id UNION SELECT 216 AS category_id UNION SELECT 217 AS category_id UNION SELECT 4 AS category_id UNION SELECT 477 AS category_id UNION SELECT 45 AS category_id UNION SELECT 10 AS category_id UNION SELECT 9 AS category_id UNION SELECT 11 AS category_id UNION SELECT 65 AS category_id UNION SELECT 64 AS category_id UNION SELECT 63 AS category_id UNION SELECT 61 AS category_id UNION SELECT 57 AS category_id UNION SELECT 56 AS category_id UNION SELECT 53 AS category_id UNION SELECT 52 AS category_id UNION SELECT 48 AS category_id UNION SELECT 47 AS category_id UNION SELECT 46 AS category_id UNION SELECT 43 AS category_id UNION SELECT 44 AS category_id UNION SELECT 66 AS category_id UNION SELECT 67 AS category_id UNION SELECT 68 AS category_id UNION SELECT 69 AS category_id UNION SELECT 70 AS category_id UNION SELECT 73 AS category_id UNION SELECT 74 AS category_id UNION SELECT 75 AS category_id UNION SELECT 76 AS category_id UNION SELECT 77 AS category_id UNION SELECT 79 AS category_id UNION SELECT 80 AS category_id UNION SELECT 81 AS category_id UNION SELECT 82 AS category_id UNION SELECT 83 AS category_id UNION SELECT 84 AS category_id UNION SELECT 87 AS category_id UNION SELECT 88 AS category_id UNION SELECT 89 AS category_id UNION SELECT 93 AS category_id UNION SELECT 95 AS category_id UNION SELECT 97 AS category_id UNION SELECT 98 AS category_id UNION SELECT 102 AS category_id UNION SELECT 103 AS category_id UNION SELECT 109 AS category_id UNION SELECT 112 AS category_id UNION SELECT 113 AS category_id UNION SELECT 114 AS category_id UNION SELECT 116 AS category_id UNION SELECT 117 AS category_id UNION SELECT 119 AS category_id UNION SELECT 122 AS category_id UNION SELECT 123 AS category_id UNION SELECT 124 AS category_id UNION SELECT 126 AS category_id UNION SELECT 133 AS category_id UNION SELECT 134 AS category_id UNION SELECT 137 AS category_id UNION SELECT 142 AS category_id UNION SELECT 146 AS category_id UNION SELECT 149 AS category_id UNION SELECT 153 AS category_id UNION SELECT 155 AS category_id UNION SELECT 158 AS category_id UNION SELECT 160 AS category_id UNION SELECT 162 AS category_id UNION SELECT 163 AS category_id UNION SELECT 169 AS category_id UNION SELECT 176 AS category_id UNION SELECT 185 AS category_id UNION SELECT 193 AS category_id UNION SELECT 194 AS category_id UNION SELECT 196 AS category_id UNION SELECT 197 AS category_id UNION SELECT 198 AS category_id UNION SELECT 199 AS category_id UNION SELECT 200 AS category_id UNION SELECT 202 AS category_id UNION SELECT 205 AS category_id UNION SELECT 207 AS category_id UNION SELECT 208 AS category_id UNION SELECT 209 AS category_id UNION SELECT 210 AS category_id UNION SELECT 211 AS category_id UNION SELECT 228 AS category_id UNION SELECT 221 AS category_id UNION SELECT 224 AS category_id UNION SELECT 225 AS category_id UNION SELECT 238 AS category_id UNION SELECT 249 AS category_id UNION SELECT 250 AS category_id UNION SELECT 254 AS category_id UNION SELECT 255 AS category_id UNION SELECT 256 AS category_id UNION SELECT 258 AS category_id UNION SELECT 259 AS category_id UNION SELECT 263 AS category_id UNION SELECT 264 AS category_id UNION SELECT 265 AS category_id UNION SELECT 266 AS category_id UNION SELECT 267 AS category_id UNION SELECT 268 AS category_id UNION SELECT 269 AS category_id UNION SELECT 270 AS category_id UNION SELECT 271 AS category_id UNION SELECT 272 AS category_id UNION SELECT 274 AS category_id UNION SELECT 275 AS category_id UNION SELECT 276 AS category_id UNION SELECT 277 AS category_id UNION SELECT 278 AS category_id 
	AS c ON (c.category_id=r.category_id)) AS br ON (b.book_id=br.book_id)
WHERE 1

половину пришлось отрезать - форма не пускала. Общая длина запроса - более 12k
задача - выбрать кол-во книг из текущей категории и всех вложенных

IntenT, 18 Июня 2012

Комментарии (23)

PHP / Говнокод #11016

+153

01
02
03
04
05
06
07
08
09
10
11
12
13

<ul class="menu">
  <li class="leaf first">
    <a href="http://example.com/app1?operator=<!--{cke_protected}
      <?php echo($user->profile_crm_name); ?>
      -->" target="_blank">Заявка №1</a>
  </li>
  <li class="leaf">
    <a href="http://example.com/app2?operator=<!--{cke_protected}
      <?php echo($user->profile_crm_name); ?>
      -->" target="_blank">Заявка №2</a>
  </li>
  <!-- ... еще десяток ... -->
</ul>

Drupal, приложение для колл-центра, пользовательский блок со списком ссылок. {cke_protected} - защита от WYSIWYG-редактора.

Спасибо, что хоть без SQL

scriptin, 17 Июня 2012

Комментарии (3)

Говнокод: по колено в коде.