По колено в коде — Говнокод.ру

PHP / Говнокод #17621

+156

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76

function form_xml_items( $sXML, $reserve, $exchange ){
	foreach ($exchange as $in => $outs) {

		$currency_in = taxonomy_term_load($in);
		switch ($in) {
			case 6:
				$currency_in->name = 'CASHUAH';
				break;
			case 18:
				$currency_in->name = 'CASHUSD';
				break;

// ...

				$currency_in->name = 'TBRUB';
				break;
			case 161:
				$currency_in->name = 'OPB';
				break;
		}

		foreach ($outs as $out => $param) {

			$currency_out = taxonomy_term_load($out);

			switch ($out) {
				case 11:
					$currency_out->name ='CASHUAH';
					break;
				case 19:
					$currency_out->name ='CASHUSD';
					break;

// ...

                               case 155:
					$currency_out->name = 'CARDRUB';
					$currency_out->second_name = 'WIRERUB';
					break;
				case 162:
					$currency_out->name = 'OPB';
					break;
			}

			$sXML .= "<item>\n";
			$sXML .= "<from>" . $currency_in->name . "</from>\n";
			$sXML .= "<to>" . $currency_out->name  . "</to>\n";
			$sXML .= "<in>1</in>\n";
			$sXML .= "<out>" . $param["rate"] . "</out>\n";
			$sXML .= "<amount>" . $param["reserve"] . "</amount>\n";
			$sXML .= "</item>\n";
			//wire and card in
			if (isset( $currency_in->second_name)){
				$sXML .= "<item>\n";
				$sXML .= "<from>" . $currency_in->second_name . "</from>\n";
				$sXML .= "<to>" . $currency_out->name  . "</to>\n";
				$sXML .= "<in>1</in>\n";
				$sXML .= "<out>" . $param["rate"] . "</out>\n";
				$sXML .= "<amount>" . $param["reserve"] . "</amount>\n";
				$sXML .= "</item>\n";
			}
			//wire and card out 
			if (isset($currency_out->second_name)){
				$sXML .= "<item>\n";
				$sXML .= "<from>" . $currency_in->name . "</from>\n";
				$sXML .= "<to>" . $currency_out->second_name  . "</to>\n";
				$sXML .= "<in>1</in>\n";
				$sXML .= "<out>" . $param["rate"] . "</out>\n";
				$sXML .= "<amount>" . $param["reserve"] . "</amount>\n";
				$sXML .= "</item>\n";
			}
		}

	}
	return $sXML;
}

Если не взирать на магические числа, кажеться этот код должен занимать строк 20, а не 130

kissarat, 11 Февраля 2015

Комментарии (0)

JavaScript / Говнокод #17620

+160

1
2

var hgh = $(document).height() - 320 - 180 - 440;
$(".message-form").height(  hgh );

шта?

heyzea1, 11 Февраля 2015

Комментарии (15)

C++ / Говнокод #17619

+53

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16

{
   ...
   _tswfstring contentID = fileName;
   _tswfstring::size_type index = fileName.find_last_of ( _T("\\")  );
   if ( index != -1 )
      contentID.erase(0, index + 1);

   TCHAR name[10] = {0};
   memcpy(name, contentID.c_str() + contentID.length() - 9, 9 * sizeof(TCHAR));
   if(name[6] == _T('B') || name[6] == _T('b')) //to upper case if .bmp
   {
      name[6] = _T('B');
      name[7] = _T('M');
      name[8] = _T('P');
   }
}

blackhearted, 11 Февраля 2015

Комментарии (1)

Python / Говнокод #17617

−109

1
2

if form.cleaned_data.has_key('replace_id') and type(form.cleaned_data['replace_id']) == type(32):
    ...

Логично, чо

larikov, 11 Февраля 2015

Комментарии (1)

C++ / Говнокод #17616

+55

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48

uint8_t const Q_ROM QF_div8Lkup[65] = {
    static_cast<uint8_t>(0), // unused location
    static_cast<uint8_t>(0), static_cast<uint8_t>(0), static_cast<uint8_t>(0),
    static_cast<uint8_t>(0), static_cast<uint8_t>(0), static_cast<uint8_t>(0),
    static_cast<uint8_t>(0), static_cast<uint8_t>(0),
    static_cast<uint8_t>(1), static_cast<uint8_t>(1), static_cast<uint8_t>(1),
    static_cast<uint8_t>(1), static_cast<uint8_t>(1), static_cast<uint8_t>(1),
    static_cast<uint8_t>(1), static_cast<uint8_t>(1),
    static_cast<uint8_t>(2), static_cast<uint8_t>(2), static_cast<uint8_t>(2),
    static_cast<uint8_t>(2), static_cast<uint8_t>(2), static_cast<uint8_t>(2),
    static_cast<uint8_t>(2), static_cast<uint8_t>(2),
    static_cast<uint8_t>(3), static_cast<uint8_t>(3), static_cast<uint8_t>(3),
    static_cast<uint8_t>(3), static_cast<uint8_t>(3), static_cast<uint8_t>(3),
    static_cast<uint8_t>(3), static_cast<uint8_t>(3),
    static_cast<uint8_t>(4), static_cast<uint8_t>(4), static_cast<uint8_t>(4),
    static_cast<uint8_t>(4), static_cast<uint8_t>(4), static_cast<uint8_t>(4),
    static_cast<uint8_t>(4), static_cast<uint8_t>(4),
    static_cast<uint8_t>(5), static_cast<uint8_t>(5), static_cast<uint8_t>(5),
    static_cast<uint8_t>(5), static_cast<uint8_t>(5), static_cast<uint8_t>(5),
    static_cast<uint8_t>(5), static_cast<uint8_t>(5),
    static_cast<uint8_t>(6), static_cast<uint8_t>(6), static_cast<uint8_t>(6),
    static_cast<uint8_t>(6), static_cast<uint8_t>(6), static_cast<uint8_t>(6),
    static_cast<uint8_t>(6), static_cast<uint8_t>(6),
    static_cast<uint8_t>(7), static_cast<uint8_t>(7), static_cast<uint8_t>(7),
    static_cast<uint8_t>(7), static_cast<uint8_t>(7), static_cast<uint8_t>(7),
    static_cast<uint8_t>(7), static_cast<uint8_t>(7)
};

// ....

    //! the function evaluates to TRUE if the priority set has the element n.
    bool hasElement(uint_fast8_t const n) const {
        uint_fast8_t const m =
            static_cast<uint_fast8_t>(Q_ROM_BYTE(QF_div8Lkup[n]));
        return ((m_bits[m]
                  & static_cast<uint_fast8_t>(Q_ROM_BYTE(QF_pwr2Lkup[n])))
               != static_cast<uint_fast8_t>(0));
    }

    //! insert element \a n into the set, n = 1..64
    void insert(uint_fast8_t const n) {
        uint_fast8_t m =
            static_cast<uint_fast8_t>(Q_ROM_BYTE(QF_div8Lkup[n]));
        m_bits[m] |= static_cast<uint_fast8_t>(Q_ROM_BYTE(QF_pwr2Lkup[n]));
        m_bytes   |=
            static_cast<uint_fast8_t>(Q_ROM_BYTE(QF_pwr2Lkup[m
                                          + static_cast<uint_fast8_t>(1)]));
    }

делим на 8 в индустриальном С++. это такой специальный вариант крестов где пользователям сначала лоботомию делают.

из реализации bitset'а. insert() приведен в качестве примера.

Dummy00001, 11 Февраля 2015

Комментарии (16)

PHP / Говнокод #17615

+155

1
2
3
4
5

if (in_array ($v["field_currency_out"]["und"][0]["tid"], array(20, 21, 26, 27,153,157,154,152,155,162)) || in_array ($v["field_currency_in"]["und"][0]["tid"], array(22, 23, 24, 25,151,156,150,149,148,161))) {
    $v["field_payment"]["und"][0]["tid"] = 28;
} else {
    $v["field_payment"]["und"][0]["tid"]= 13;
}

Представте что весь сайт написан в этом же духе.
Причем мы имеем дело с двома наборами констант для обозначения валют - для входа и выхода перевода.

kissarat, 10 Февраля 2015

Комментарии (6)

PHP / Говнокод #17614

+156

1
2

$dateStart = "2015-01-01";
$dateEnd = date("Y-m-d", strtotime(date("Y-m-01", strtotime(date("Y-m-d", strtotime("+1 month", strtotime($dateStart))))) . " -1 day"));

Вычисляем последний день месяца

chumoleg, 10 Февраля 2015

Комментарии (7)

PHP / Говнокод #17613

+157

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40

/**
	 * @return DevblocksSearchField[]
	 */
	static function getFields() {
		$translate = DevblocksPlatform::getTranslationService();
		
		$columns = array(
			SearchFields_Ticket::TICKET_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_ID, 't', 'id', $translate->_('common.id'), Model_CustomField::TYPE_NUMBER),
			SearchFields_Ticket::TICKET_MASK => new DevblocksSearchField(SearchFields_Ticket::TICKET_MASK, 't', 'mask', $translate->_('ticket.mask'), Model_CustomField::TYPE_SINGLE_LINE),
			SearchFields_Ticket::TICKET_SUBJECT => new DevblocksSearchField(SearchFields_Ticket::TICKET_SUBJECT, 't', 'subject', $translate->_('ticket.subject'), Model_CustomField::TYPE_SINGLE_LINE),
			
			SearchFields_Ticket::TICKET_FIRST_MESSAGE_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_MESSAGE_ID, 't', 'first_message_id'),
			SearchFields_Ticket::TICKET_FIRST_OUTGOING_MESSAGE_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_OUTGOING_MESSAGE_ID, 't', 'first_outgoing_message_id'),
			SearchFields_Ticket::TICKET_LAST_MESSAGE_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_LAST_MESSAGE_ID, 't', 'last_message_id'),
			
			SearchFields_Ticket::TICKET_FIRST_WROTE_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE_ID, 't', 'first_wrote_address_id'),
			SearchFields_Ticket::TICKET_FIRST_WROTE => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE, 'a1', 'email',$translate->_('ticket.first_wrote'), Model_CustomField::TYPE_SINGLE_LINE),
			SearchFields_Ticket::TICKET_FIRST_WROTE_FIRST_NAME => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE_FIRST_NAME, 'a1', 'first_name', $translate->_('ticket.first_wrote') . ' First Name'),
			SearchFields_Ticket::TICKET_FIRST_WROTE_LAST_NAME => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE_LAST_NAME, 'a1', 'last_name', $translate->_('ticket.first_wrote') . ' Last Name'),
			SearchFields_Ticket::TICKET_FIRST_WROTE_SPAM => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE_SPAM, 'a1', 'num_spam',$translate->_('address.num_spam'), Model_CustomField::TYPE_NUMBER),
			SearchFields_Ticket::TICKET_FIRST_WROTE_NONSPAM => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE_NONSPAM, 'a1', 'num_nonspam',$translate->_('address.num_nonspam'), Model_CustomField::TYPE_NUMBER),
				
			SearchFields_Ticket::TICKET_LAST_WROTE_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_LAST_WROTE_ID, 't', 'last_wrote_address_id'),
			SearchFields_Ticket::TICKET_LAST_WROTE => new DevblocksSearchField(SearchFields_Ticket::TICKET_LAST_WROTE, 'a2', 'email',$translate->_('ticket.last_wrote'), Model_CustomField::TYPE_SINGLE_LINE),
			SearchFields_Ticket::TICKET_LAST_WROTE_FIRST_NAME => new DevblocksSearchField(SearchFields_Ticket::TICKET_LAST_WROTE_FIRST_NAME, 'a2', 'first_name', $translate->_('ticket.last_wrote') . ' First Name'),
			SearchFields_Ticket::TICKET_LAST_WROTE_LAST_NAME => new DevblocksSearchField(SearchFields_Ticket::TICKET_LAST_WROTE_LAST_NAME, 'a2', 'last_name', $translate->_('ticket.last_wrote') . ' Last Name'),
				
			SearchFields_Ticket::ORG_NAME => new DevblocksSearchField(SearchFields_Ticket::ORG_NAME, 'o', 'name', $translate->_('contact_org.name'), Model_CustomField::TYPE_SINGLE_LINE),
			SearchFields_Ticket::REQUESTER_ADDRESS => new DevblocksSearchField(SearchFields_Ticket::REQUESTER_ADDRESS, 'ra', 'email',$translate->_('ticket.requester'), Model_CustomField::TYPE_SINGLE_LINE),
			
			SearchFields_Ticket::TICKET_ORG_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_ORG_ID, 't','org_id',$translate->_('contact_org.id')),
			SearchFields_Ticket::TICKET_OWNER_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_OWNER_ID,'t','owner_id',$translate->_('common.owner'), Model_CustomField::TYPE_WORKER),
			SearchFields_Ticket::TICKET_GROUP_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_GROUP_ID,'t','group_id',$translate->_('common.group')),
			SearchFields_Ticket::TICKET_BUCKET_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_BUCKET_ID, 't', 'bucket_id',$translate->_('common.bucket')),
			SearchFields_Ticket::TICKET_CREATED_DATE => new DevblocksSearchField(SearchFields_Ticket::TICKET_CREATED_DATE, 't', 'created_date',$translate->_('common.created'), Model_CustomField::TYPE_DATE),
			SearchFields_Ticket::TICKET_UPDATED_DATE => new DevblocksSearchField(SearchFields_Ticket::TICKET_UPDATED_DATE, 't', 'updated_date',$translate->_('common.updated'), Model_CustomField::TYPE_DATE),
			SearchFields_Ticket::TICKET_CLOSED_AT => new DevblocksSearchField(SearchFields_Ticket::TICKET_CLOSED_AT, 't', 'closed_at',$translate->_('ticket.closed_at'), Model_CustomField::TYPE_DATE),
			SearchFields_Ticket::TICKET_WAITING => new DevblocksSearchField(SearchFields_Ticket::TICKET_WAITING, 't', 'is_waiting',$translate->_('status.waiting'), Model_CustomField::TYPE_CHECKBOX),
			SearchFields_Ticket::TICKET_CLOSED => new DevblocksSearchField(SearchFields_Ticket::TICKET_CLOSED, 't', 'is_closed',$translate->_('status.closed'), Model_CustomField::TYPE_CHECKBOX),
			SearchFields_Ticket::TICKET_DELETED => new DevblocksSearchField(SearchFields_Ticket::TICKET_DELETED, 't', 'is_deleted',$translate->_('status.deleted'), Model_CustomField::TYPE_CHECKBOX),

https://github.com/jstanden/cerb6/blob/6.9.1/features/cerberusweb.core/api/dao/ticket.php#L1979

lav45, 10 Февраля 2015

Комментарии (2)

C++ / Говнокод #17612

+53

1
2
3
4
5
6

static uint8_t const FREE = static_cast<uint8_t>(0);
static uint8_t const USED = static_cast<uint8_t>(1);

static char_t const * const THINKING = &"thinking"[0];
static char_t const * const HUNGRY   = &"hungry  "[0];
static char_t const * const EATING   = &"eating  "[0];

Из демы QP/C++ библиотеки. Вот в таком духе очень много кода.

Индустриальщики, после перехода на С++, похоже очень сильно страдают по отсутствию pre-ANSI C какашек, и изобретают новые.

Dummy00001, 10 Февраля 2015

Комментарии (8)

JavaScript / Говнокод #17611

+161

1

this.$items = this.$items.last().add(this.$items.not(this.$items.last()));

this.$items – jQuery многоножка

fake, 10 Февраля 2015

Комментарии (3)

Говнокод: по колено в коде.