Говнокод: по колено в коде.

• Все
• Лучший
• Сток
• Глупый поиск
• Наговнокодить!
• Oтзывы

Нашли или выдавили из себя код, который нельзя назвать нормальным, на который без улыбки не взглянешь? Не торопитесь его удалять или рефакторить, — запостите его на говнокод.ру, посмеёмся вместе!

1. PHP (5708)
2. C++ (2739)
3. Куча (2379)
4. JavaScript (2032)
5. C# (1929)
6. Java (1502)
7. Си (1117)
8. Pascal (648)
9. Python (591)
10. 1C (539)
11. SQL (432)
12. ActionScript (292)
13. Objective C (202)
14. bash (200)
15. Perl (194)
16. Assembler (146)
17. Ruby (145)
18. VisualBasic (138)
19. Lua (49)
20. Haskell (34)
21. Go (31)
22. Swift (27)
23. Kotlin (14)

1. JavaScript / Говнокод #5986

   +169

   1. 1
   2. 2
   3. 3
   4. 4
   5. 5
   6. 6

   function isTheSame(string1, string2) {
   	var firstResult =new RegExp(string1).test(string2); 
   	var secondResult =new RegExp(string2).test(string1);
   	var commonResult = firstResult && secondResult;
   	return commonResult;
   }

   tr00_gr1m_doomster, 15 Марта 2011

   Комментарии (9)

2. C# / Говнокод #5985

   +126

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24
   25. 25
   26. 26
   27. 27
   28. 28
   29. 29
   30. 30
   31. 31
   32. 32
   33. 33
   34. 34
   35. 35
   36. 36

   public class BasisTariffing : IFormattable
   {
   	public override bool Equals(object obj) {
   		BasisTariffing subject = obj as BasisTariffing;
   		if (subject == null) {
   			return false;
   		}
   		return ((Profession == null && subject.Profession == null) || (Profession != null && subject.Profession != null && Profession.Equals(subject.Profession))) &&
   			((BasisRateOf == null && subject.BasisRateOf == null) || (BasisRateOf != null && subject.BasisRateOf != null && BasisRateOf.Equals(subject.BasisRateOf))) &&
   			((BasisRating1Main == null && subject.BasisRating1Main == null) || (BasisRating1Main != null && subject.BasisRating1Main != null && BasisRating1Main.Equals(subject.BasisRating1Main))) &&
   			((BasisRating1Add == null && subject.BasisRating1Add == null) || (BasisRating1Add != null && subject.BasisRating1Add != null && BasisRating1Add.Equals(subject.BasisRating1Add))) &&
   			((BasisRating2Main == null && subject.BasisRating2Main == null) || (BasisRating2Main != null && subject.BasisRating2Main != null && BasisRating2Main.Equals(subject.BasisRating2Main))) &&
   			((BasisRating2Add == null && subject.BasisRating2Add == null) || (BasisRating2Add != null && subject.BasisRating2Add != null && BasisRating2Add.Equals(subject.BasisRating2Add))) &&
   			((BasisRating3Main == null && subject.BasisRating3Main == null) || (BasisRating3Main != null && subject.BasisRating3Main != null && BasisRating3Main.Equals(subject.BasisRating3Main))) &&
   			((BasisRating3Add == null && subject.BasisRating3Add == null) || (BasisRating3Add != null && subject.BasisRating3Add != null && BasisRating3Add.Equals(subject.BasisRating3Add))) &&
   			((BasisRating4Main == null && subject.BasisRating4Main == null) || (BasisRating4Main != null && subject.BasisRating4Main != null && BasisRating4Main.Equals(subject.BasisRating4Main))) &&
   			((BasisRating4Add == null && subject.BasisRating4Add == null) || (BasisRating4Add != null && subject.BasisRating4Add != null && BasisRating4Add.Equals(subject.BasisRating4Add))) &&
   			((BasisRating5Main == null && subject.BasisRating5Main == null) || (BasisRating5Main != null && subject.BasisRating5Main != null && BasisRating5Main.Equals(subject.BasisRating5Main))) &&
   			((BasisRating5Add == null && subject.BasisRating5Add == null) || (BasisRating5Add != null && subject.BasisRating5Add != null && BasisRating5Add.Equals(subject.BasisRating5Add))) &&
   			((BasisRating6Main == null && subject.BasisRating6Main == null) || (BasisRating6Main != null && subject.BasisRating6Main != null && BasisRating6Main.Equals(subject.BasisRating6Main))) &&
   			((BasisRating6Add == null && subject.BasisRating6Add == null) || (BasisRating6Add != null && subject.BasisRating6Add != null && BasisRating6Add.Equals(subject.BasisRating6Add))) &&
   			((BasisRating7Main == null && subject.BasisRating7Main == null) || (BasisRating7Main != null && subject.BasisRating7Main != null && BasisRating7Main.Equals(subject.BasisRating7Main))) &&
   			((BasisRating7Add == null && subject.BasisRating7Add == null) || (BasisRating7Add != null && subject.BasisRating7Add != null && BasisRating7Add.Equals(subject.BasisRating7Add))) &&
   			((BasisRating8Main == null && subject.BasisRating8Main == null) || (BasisRating8Main != null && subject.BasisRating8Main != null && BasisRating8Main.Equals(subject.BasisRating8Main))) &&
   			((BasisRating8Add == null && subject.BasisRating8Add == null) || (BasisRating8Add != null && subject.BasisRating8Add != null && BasisRating8Add.Equals(subject.BasisRating8Add)));
   	}
   
   	public override int GetHashCode() {
   		return ((Profession != null) ? Profession.GetHashCode() : 0) ^
   			((BasisRateOf != null) ? BasisRateOf.GetHashCode() : 0) ^
   			((BasisRating1Main != null) ? BasisRating1Main.GetHashCode() : 0) ^
   			((BasisRating1Add != null) ? BasisRating1Add.GetHashCode() : 0) ^
   			((BasisRating2Main != null) ? BasisRating2Main.GetHashCode() : 0) ^
   			....................................
   	}
   }

   Как вам перегрузочка? И это только часть кода *сущности*, больше просто не вместилось =)

   Guid, 15 Марта 2011

   Комментарии (9)

3. PHP / Говнокод #5984

   +156

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13

   $properties_array = array_keys($this->values);
               array_unshift($properties_array, $properties_array[0]);
               unset($properties_array[0]);
               $properties_values_array = array_values($properties_array);
               $values_array = array_values($this->values);
               $properties = implode('` ,`', $properties_values_array);
               $values = implode(', ', array_fill(0, count($this->values), '?'));
               $result = self::$orm->db->prepare('INSERT INTO `' . $this->table . '`  (`' . $properties . '`) values (' . $values . ')');
               foreach ($values_array as $key => $value) {
                   $fieldinfo = $this->fields[$properties_values_array[$key]];
                   $result->bindParam($key + 1, $values_array[$key], $this->correctDataType($fieldinfo['native_type'], $fieldinfo['pdo_type']), $fieldinfo['len']);
               }
               $result->execute();

   Чувствую код плохо пахнет, надо разбирать)) Высоко нагруженный проект ;)

   PANACEA, 15 Марта 2011

   Комментарии (7)

4. 1C / Говнокод #5983

   −110

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13

   СписокЗначенийТиповЦен = Новый СписокЗначений;
   ...
   КоличествоЦен = 0;
   РезультатВыбора = ФормаВыбораТиповЦен.ОткрытьМодально();
   Для Каждого Элемент Из РезультатВыбора Цикл 
   	СписокЗначенийТиповЦен.Добавить(Элемент.Значение);
   	КоличествоЦен = КоличествоЦен + 1;
   КонецЦикла;
   
   Если КоличествоЦен = 0 Тогда
   	Предупреждение("Не выбран ни один тип цен!!!");	
   	Возврат;
   КонецЕсли;

   Нет проверки на возвращение "неопределено" в строке 4. К тому же в результате возвращает список значений, зачем создавать еще один список и все элементы переносить в него для меня загадка.
   Ну и счетчик количества элементов в цикле вместо РезультатВыбора.Количество() на десерт.

   ingenuus, 14 Марта 2011

   Комментарии (13)

5. C++ / Говнокод #5982

   +160

   1. 1
   2. 2

   float alpha = float(m_startAlpha) + 255.0f * (getElapsed() / (m_duration * (1.0f - float(m_startAlpha) / 255.0f)));
   m_target->setAlpha(static_cast<uint8_t>(alpha));

   Выдержка из обновления объекта-действия, производящего линейный фейд-аут объекта...
   
   Общение с чужим говнокодом не проходит бесследно... что же я курил, перед тем как ЭТО соорудить?

   Kirinyale, 14 Марта 2011

   Комментарии (5)

6. Си / Говнокод #5981

   +132

   1. 1
   2. 2
   3. 3
   4. 4
   5. 5
   6. 6
   7. 7

   if (argc == 3)
       snprintf(outfile, sizeof(outfile) - 1, "scan.log", argv[1], argv[2]);
   else if (argc >= 4)
   {
       snprintf(outfile, sizeof(outfile) - 1, "scan.log", argv[1], argv[3], argv[2]);
       // ...
   }

   Какой-то иксплойт, файл pscan2.c

   raorn, 14 Марта 2011

   Комментарии (15)

7. Си / Говнокод #5980

   +138

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12

   int ftp_list (int sck, int verbose) {
   	/* ... */
   	list = fopen("LIST.txt", "w");
   
   	if (list == NULL) {
   		printf("Unable to open LIST file..\n");
   		free(buffer);
   		
   		return -1;
   	}
   	/* ... */
   }

   Функция получения списка файлов в директории с FTP-сервера.
   http://sourceforge.net/projects/libftp/

   EmbargEr, 14 Марта 2011

   Комментарии (7)

8. SQL / Говнокод #5979

   −851

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24
   25. 25
   26. 26
   27. 27
   28. 28
   29. 29
   30. 30
   31. 31
   32. 32
   33. 33
   34. 34

   select distinct bk.ID, bk.URL, bk.Date, bk.Name, bk.Description, bk.UserCreatorID from bookmarking_bookmark as bk 
   where bk.Tenant=@Tenant and bk.ID in 
   (select *  from (select b.ID  from bookmarking_bookmark as b  left join  bookmarking_bookmarktag as bt on b.ID=bt.BookmarkID left join bookmarking_tag as t  on bt.TagID=t.TagID 
   left join (select ub.BookmarkID as BookmarkID, ub.Name as UserBookmarkName,ub.Description as UserBookmarkDescription, t.Name as TagName  
   from (select * from bookmarking_userbookmark as ub where ub.UserID=@userID) as ub 
   left join bookmarking_userbookmarktag as ubt  on ub.UserBookmarkID=ubt.UserBookmarkID  
   left join bookmarking_tag as t  on ubt.TagID=t.TagID) as ub on b.ID=ub.BookmarkID 
   where  ( ( lower(b.URL) like lower(@tagNameForUrlWithoutLastSlash0) )  
   or (lower(b.Name) like lower(@tagName0) or lower(b.Name) like lower(@tagNameWithSpace0)) 
   or (lower(b.Description) like lower(@tagName0) or lower(b.Description) like lower(@tagNameWithSpace0))    
   or (lower(t.Name) like lower(@tagName0)) or (lower(t.Name)  like lower(@tagNameWithSpace0)) 
   or (lower(TagName) like lower(@tagName0)) or (lower(TagName) like lower(@tagNameWithSpace0))    
   or (lower(UserBookmarkName) like lower(@tagName0) or lower(UserBookmarkName) like lower(@tagNameWithSpace0))    
   or (lower(UserBookmarkDescription) like lower(@tagName0) or lower(UserBookmarkDescription) like lower(@tagNameWithSpace0)))  
   and b.ID in (
   select b.ID   from bookmarking_bookmark as b  left join  bookmarking_bookmarktag as bt  on b.ID=bt.BookmarkID
   left join bookmarking_tag as t    on bt.TagID=t.TagID 
   left join  (
   select ub.BookmarkID as BookmarkID, ub.Name as UserBookmarkName, ub.Description as UserBookmarkDescription, t.Name as TagName from 
   (select * from bookmarking_userbookmark as ub where ub.UserID=@userID) as ub  
   left join bookmarking_userbookmarktag as ubt on ub.UserBookmarkID=ubt.UserBookmarkID
   left join bookmarking_tag as t on ubt.TagID=t.TagID) as ub on b.ID=ub.BookmarkID
   where  (( lower(b.URL) like lower(@tagNameForUrlWithoutLastSlash1) ) or (lower(b.Name) like lower(@tagName1) or lower(b.Name) like lower(@tagNameWithSpace1)) 
   or (lower(b.Description) like lower(@tagName1) or lower(b.Description) like lower(@tagNameWithSpace1)) or (lower(t.Name) like lower(@tagName1)) 
   or (lower(t.Name)  like lower(@tagNameWithSpace1)) or (lower(TagName) like lower(@tagName1)) or (lower(TagName) like lower(@tagNameWithSpace1))  
   or (lower(UserBookmarkName) like lower(@tagName1) or lower(UserBookmarkName) like lower(@tagNameWithSpace1)) or (lower(UserBookmarkDescription)
   like lower(@tagName1) or lower(UserBookmarkDescription) like lower(@tagNameWithSpace1))) and b.ID in (
   select b.ID from bookmarking_bookmark as b left join bookmarking_bookmarktag as bt on b.ID=bt.BookmarkID left join bookmarking_tag as t on bt.TagID=t.TagID left join
   (select ub.BookmarkID as BookmarkID, ub.Name as UserBookmarkName,  ub.Description as UserBookmarkDescription, t.Name as TagName 
   from (select * from bookmarking_userbookmark as ub where ub.UserID=@userID) as ub 
   left join bookmarking_userbookmarktag as ubt on ub.UserBookmarkID=ubt.UserBookmarkID  left join bookmarking_tag as t on ubt.TagID=t.TagID) as ub on b.ID=ub.BookmarkID
   where (( lower(b.URL) like lower(@tagNameForUrlWithoutLastSlash2) ) or (lower(b.Name) like lower(@tagName2) or lower(b.Name) like lower(@tagNameWithSpace2))
   or (lower(b.Description) like lower(@tagName2) or lower(b.Description) like lower(@tagNameWithSpace2)) or (lower(t.Name) like lower(@tagName2)) or (lower(t.Name)
   like lower(@tagNameWithSpace2)) or....

   среднее время выполнения 30 секунд

   arusanov, 14 Марта 2011

   Комментарии (115)

9. SQL / Говнокод #5978

   −864

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24
   25. 25
   26. 26
   27. 27
   28. 28
   29. 29
   30. 30
   31. 31
   32. 32
   33. 33
   34. 34
   35. 35
   36. 36
   37. 37
   38. 38
   39. 39

   SELECT foo.oper_id,
   	                     foo.client_id,
   			     base_clients.name,
   			     base_clients.options,
   			     base_providers.name,
   	  		     base_subproviders.name,
   			     base_clients.address_post,
   			     base_clients.balance,
   			     base_currency_types.descr,
   			     base_clients.descr,
   			     base_clients.client_type,
   			     base_clients.pdn_permission_taken,
   			     base_clients.person_use_srv_as_org,
   	             base_clients.none_client
   		      FROM   (SELECT oper_id,client_id FROM base_clients WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )   AND ( base_clients.client_id = '681843' OR base_clients.personal_id = '681843' OR base_clients.name ~ '[66][88][11][88][44][33]' OR base_clients.address_post ILIKE  '%681843%'OR base_clients.descr ILIKE '%681843%' )  UNION SELECT DISTINCT oper_id,client_id FROM telephone_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM channel_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM dry_pair_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM inet_dynamic_ip_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   
   				UNION 
   				    SELECT DISTINCT sss.oper_id, sss.client_id 
   					FROM inet_fixed_ip_services as sss
   					    left join inet_fixed_ip_group_items as itms on (sss.oper_id = itms.oper_id and sss.user_id = itms.ip_group )
   				    WHERE 
   					 (  sss.oper_id = 'TT'  OR sss.oper_id = 'SC'  OR sss.oper_id = 'TT2'  OR sss.oper_id = 'RC'  )  AND 
   					(  
   					    sss.user_id ILIKE '%681843%'  
   						OR
   					    itms.ip ILIKE '%681843%'  
   					)
   			     UNION SELECT DISTINCT oper_id,client_id FROM unix_shell_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM voip_ip_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM voip_card_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM ani_phone_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'   UNION SELECT DISTINCT oper_id,client_id FROM cable_tv_services WHERE  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  AND user_id ILIKE '%681843%'  UNION select distinct oper_id,client_id from base_client_aon_list where caller_phone = '681843' AND  (  oper_id = 'TT'  OR oper_id = 'SC'  OR oper_id = 'TT2'  OR oper_id = 'RC'  )  ) AS foo 
   		             JOIN 
   			     base_clients ON foo.oper_id=base_clients.oper_id AND 
   			                     foo.client_id=base_clients.client_id 
   			     JOIN 
   			     base_providers ON base_clients.oper_id=base_providers.oper_id 
   			     JOIN 
   			     base_currency_types ON base_clients.oper_id=base_currency_types.oper_id AND 
   			                            base_clients.currency_type=base_currency_types.currency_type
   	                     LEFT JOIN
   			     base_subproviders ON base_clients.oper_id=base_subproviders.oper_id AND
   	                                          base_clients.suboper_id=base_subproviders.suboper_id 
   	              ORDER BY to_number(base_clients.client_id,'999999999') DESC

   Это запрос на простой поиск клиента в биллинге.

   spaceoflabview, 14 Марта 2011

   Комментарии (3)

10. 1C / Говнокод #5977

    −92

    1. 1
    2. 2
    3. 3
    4. 4
    5. 5
    6. 6
    7. 7
    8. 8
    9. 9

    ...
    Запрос.Текст =
    "...
    |ГДЕ
    |    ...
    |    И ТипыЦенНоменклатуры.ПроцентСкидкиНаценки <> &Нуль
    |    ...";
    Запрос.УстановитьПараметр("Нуль", 0);
    ...

    ingenuus, 14 Марта 2011

    Комментарии (31)

• ← влево
• вправо →

• 2109
• …
• 592
• 591
• 590
• 589
• 588
• 587
• 586
• 585
• 584
• …
• 1