PHP — Говнокод.ру

PHP / Говнокод #14319

+152

1
2
3
4

// Сначала было 
$result['routes'][0]['legs'][0]['start_address'].split(',');
// Повтыкал с минуту, исправил на 
$result['routes'][0]['legs'][0]['start_address'].explode(',');

NodeJS головного мозга...

nonamez, 06 Января 2014

Комментарии (11)

PHP / Говнокод #14304

+156

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23

class core {
public static function txt($var){
$var = trim($var);
$var = stripslashes($var);
$var = str_replace("\00", '', $var);
$var = htmlspecialchars($var, ENT_QUOTES, 'UTF-8');
$var = str_replace("%", "\%", $var);
$var = str_replace("_", "\_", $var);
$var = iconv('utf-8', 'windows-1251', $var);
$var = iconv('windows-1251', 'utf-8', $var);
return $var;
}
public static function nik($id){
global $dbs;
$nick = $dbs->query("SELECT * FROM `users` WHERE `id` = '$id'")->fetch_assoc();
if(empty($nick)){
$us = '[Удален]';
}else{
$us = ($nick['onl']<time()-600?'<font color="red">[off]</font>':'<font color="green">[on]</font>').' <a href="/'.$nick['login'].'" style="color:black;"><b>'.$nick['login'].'</b></a>';
}
return $us;
}
/*.....и еще куча срани*/

Вот он ООП, ну и оптимизция))

Ruslyakan, 31 Декабря 2013

Комментарии (107)

PHP / Говнокод #14287

+153

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38

<?php
namespace Custom\Entity;

class slideshow{
    const IBLOCK_ID = SLIDER_ON_INDEX_IBLOCK_ID;

    static function getLabel($type){
        $label = "";
        switch($type){
            case NEW_OF_DAY_ENUM_ID_PROPERTY_MAIN_ARTICLES_IBLOCK_ID:
                $label = '<img class="sticker news_of_day" src="/static/img/labels/news_of_day_l.png"><img class="sticker news_of_day_r" src="/static/img/labels/news_of_day_r.png">';
                break;
            case HOT_ENUM_ID_PROPERTY_MAIN_ARTICLES_IBLOCK_ID:
                $label = '<img class="sticker hot infoBlock rsABlock rsNoDrag" src="/static/img/labels/hot.png">';
                break;
            case SLUH_ENUM_ID_PROPERTY_MAIN_ARTICLES_IBLOCK_ID:
                $label = '<img class="sticker infoBlock infoBlockLeftBlack rsABlock rsNoDrag" src="/static/img/labels/gossip.png">';
                break;
            case ITEM_ENUM_ID_PROPERTY_MAIN_ARTICLES_IBLOCK_ID:
                $label = '<img class="sticker thing_of_week infoBlock rsABlock rsNoDrag" src="/static/img/labels/thing_of_week.png">';
                break;
            case POPULAR_ENUM_ID_PROPERTY_MAIN_ARTICLES_IBLOCK_ID:
                $label = '<img class="sticker most_popular infoBlock rsABlock rsNoDrag" src="/static/img/labels/most_popular.png">';
                break;
            case CHOOSE_ENUM_ID_PROPERTY_MAIN_ARTICLES_IBLOCK_ID:
                $label = '<img class="sticker editors_choice infoBlock" src="/static/img/labels/editors_choice.png">';
                break;
            case BEST_ENUM_ID_PROPERTY_MAIN_ARTICLES_IBLOCK_ID:
                $label = '<img class="sticker the_best infoBlock rsABlock rsNoDrag" src="/static/img/labels/the_best.png">';
                break;
            case NEW_ENUM_ID_PROPERTY_MAIN_ARTICLES_IBLOCK_ID:
                $label = '<img class="sticker new infoBlock rsABlock rsNoDrag" src="/static/img/labels/new.png">';
                break;
        }
        return $label;
    }
}
?>

И еще один замечательный пример ChinaCode от "грамотных разработчиков на битриксе, которые знают неймспейсы". Особенно порадовал css-класс rsNoDrag, хотя по большому счету надо было бы данный класс назвать "NoDrugs" и взять на вооружение данным "пейсателям".

sturm, 26 Декабря 2013

Комментарии (3)

PHP / Говнокод #14284

+158

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63

public static function getAssoc($constBlock,$const){
        if (defined($constBlock)){
            $arLabels = unserialize($const);
            $assoc = array(
                $arLabels['news_day'] => array(
                    'img' => array(
                        0 => array(
                            'class' => 'sticker infoBlock news_of_day',
                            'big' => '/static/img/labels/news_of_day.png',
                            'small' => '/static/img/labels/news_of_day_s.png'
                        ),
                        /*1 => array(
                            'class' => 'sticker news_of_day_r',
                            'big' => '/static/img/labels/news_of_day_r.png',
                            'small' => '/static/img/labels/news_of_day_s_r.png'
                        ),*/
                    )
                ),
                $arLabels['hot'] => array(
                    'img' => array(
                        0 => array(
                            'class' => 'sticker hot infoBlock',
                            'big' => '/static/img/labels/hot.png',
                            'small' => '/static/img/labels/hot_s.png'
                        )
                    )
                ),
                $arLabels['gossip'] => array(
                    'img' => array(
                        0 => array(
                            'class' => 'sticker infoBlock gossip',
                            'big' => '/static/img/labels/gossip.png',
                            'small' => '/static/img/labels/gossip_s.png'
                        )
                    )
                ),
                $arLabels['thing_of_week'] => array(
                    'img' => array(
                        0 => array(
                            'class' => 'sticker thing_of_week infoBlock',
                            'big' => '/static/img/labels/thing_of_week.png',
                            'small' => '/static/img/labels/thing_of_week_s.png'
                        )
                    )
                ),
                ...
                ...
                ...
                ...
                ...
                $arLabels['new_role'] => array(
                    'img' => array(
                        0 => array(
                            'class' => 'sticker new_role infoBlock',
                            'big' => '/static/img/labels/new_role.png',
                            'small' => '/static/img/labels/new_role_s.png'
                        )
                    )
                )
            );
        }
        return $assoc;
    }

Так пишут "грамотные разработчики на битриксе" (они знают неймспейсы). Естественно, что все методы в классах должны быть статическими. Это по-битриксовому, значит правильно. Заполнение массива ChinaStyle, т.е. вручную - это тоже правильно, ибо тоже по-битриксовому. И конечно же, вся эта НЁХ должна храниться в текущем методе. "Циклы? Нет, не слышали... Запросы к базе данных? Битрикс говорит, что это плохо, поэтому мы с уверенностью эти лекции проебали. Зато мы знаем неймспейсы!"

sturm, 26 Декабря 2013

Комментарии (1)

PHP / Говнокод #14283

+155

1
2

$actions = new BlogsActions;
return $actions::model();

платили бы им за строчки кода...

CRRaD, 26 Декабря 2013

Комментарии (0)

PHP / Говнокод #14282

+153

01
02
03
04
05
06
07
08
09
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37

public static function translite($string) {
        $rus=array(
            "A","B","C","D","e","F","G","H","I",
            "J","K","L","M","N","O","P","Q","R",
            "S","T","U","V","W","X","Y","Z",
            "ё","й","ю","ь","ч","щ","ц","у","к",
            "е","н","г","ш","з","х","ъ","ф","ы","в",
            "а","п","р","о","л","д","ж","э","я","с",
            "м","и","т","б","Ё","Й","Ю","Ч","Ь",
            "Щ","Ц","У","К","Е","Н","Г","Ш","З",
            "Х","Ъ","Ф","Ы","В","А","П","Р","О",
            "Л","Д","Ж","Э","Я","С","М","И","Т","Б",
            "-"," ","–","?",'"',",",".","«","»","'","!",
            "/","\\",":",";","<",">","(",")","[","]",
            "{","}","@","#","№","$","%","^","&","*",
            "~");
        $eng = array(
            "a","b","c","d","e","f","g","h","i",
            "j","k","l","m","n","o","p","q","r",
            "s","t","u","v","w","x","y","z",
            "yo","iy","yu","","ch","sh","c","u","k",
            "e","n","g","sh","z","h","","f","y","v",
            "a","p","r","o","l","d","j","е","ya","s",
            "m","i","t","b","yo","iy","yu","ch","",
            "sh","c","u","k","e","n","g","sh","z",
            "h","","f","y","v","a","p","r","o",
            "l","d","j","e","ya","s","m","i","t","b",
            "_","_","_","","","","","","","","",
            "","","","","","","","","","",
            "","","","","","","","","","",
            "");
        $string = str_replace($rus, $eng,  $string);
        if(!empty($string)) {
            return $string;
        }
        else return("");
    }

Как соответсвует название функции той неведомой херне, которую она делает я так и не понял.
Столько травы у меня нет.

Homess, 26 Декабря 2013

Комментарии (10)

PHP / Говнокод #14281

+160

1
2
3

{if $smarty.foreach.categories.iteration == 2 || $smarty.foreach.categories.iteration == 4 || $smarty.foreach.categories.iteration == 6 || $smarty.foreach.categories.iteration == 8 || $smarty.foreach.categories.iteration == 10 || $smarty.foreach.categories.iteration == 12  || $smarty.foreach.categories.iteration == 14  || $smarty.foreach.categories.iteration == 16}
      <div class="clear"></div>
{/if}

Smarty

uadeveloper, 26 Декабря 2013

Комментарии (15)

PHP / Говнокод #14280

+154

1
2
3
4

if((int)$this->tmpl['detailwindow'] == 4 || (int)$this->tmpl['detailwindow'] == 5 || (int)$this->tmpl['detailwindow'] == 7) {
  } else { 
   echo '<td align="center">' . str_replace("%onclickclose%", $this->tmpl['detailwindowclose'], $this->item->closebutton). '</td>';
  }

Какая глубина мысли!
Интересно, а чтобы ОНО написало в С++?

virtual_cia, 26 Декабря 2013

Комментарии (0)

PHP / Говнокод #14273

+151

1
2
3
4
5
6
7

$proposal['categories'] = explode(',',db_get_field('
            SELECT GROUP_CONCAT(pc.category_id)
            FROM `?:proposal_categories` pc
            INNER JOIN `?:proposal` p ON pc.`proposal_id` = p.`id`
            INNER JOIN `?:proposal_category` pca ON pc.`category_id` = pca.`id`
            WHERE pca.`status` = ?s AND pc.`proposal_id` = ?i
            ORDER BY pca.position', 'A', $proposal['proposal_id']));

Нашел в собственном коде... вроде безобидно, но забавно.

Segalp, 25 Декабря 2013

Комментарии (2)

Говнокод: по колено в коде.