1. Список говнокодов пользователя tayum

    Всего: 1

  2. JavaScript / Говнокод #21875

    −47

    1. 01
    2. 02
    3. 03
    4. 04
    5. 05
    6. 06
    7. 07
    8. 08
    9. 09
    10. 10
    11. 11
    12. 12
    13. 13
    14. 14
    15. 15
    16. 16
    17. 17
    18. 18
    19. 19
    20. 20
    21. 21
    22. 22
    23. 23
    24. 24
    25. 25
    26. 26
    27. 27
    28. 28
    29. 29
    30. 30
    31. 31
    32. 32
    33. 33
    34. 34
    35. 35
    36. 36
    37. 37
    38. 38
    39. 39
    40. 40
    41. 41
    42. 42
    43. 43
    44. 44
    45. 45
    46. 46
    47. 47
    48. 48
    49. 49
    50. 50
    51. 51
    52. 52
    53. 53
    54. 54
    55. 55
    56. 56
    57. 57
    58. 58
    59. 59
    60. 60
    61. 61
    62. 62
    63. 63
    64. 64
    65. 65
    66. 66
    67. 67
    68. 68
    69. 69
    70. 70
    71. 71
    72. 72
    73. 73
    74. 74
    75. 75
    76. 76
    77. 77
    78. 78
    79. 79
    80. 80
    81. 81
    82. 82
    83. 83
    84. 84
    85. 85
    86. 86
    87. 87
    88. 88
    89. 89
    90. 90
    91. 91
    92. 92
    93. 93
    94. 94
    95. 95
    96. 96
    97. 97
    .get(csrfProtection, function(req, res, next) {
            let query = bandModel.count();
		query.exec(function(err, amount) {
			if (err) {
				err = new Error('Sorry, the file with contents were not found on server.');
				err.status = 500;
				next(err);
			}
			// None bands are in database
			else if (amount <= 0) {
				res.render('bands', {
					csrfToken: req.csrfToken(),
					curPage: 1,
					maxPage: 1,
					arr: [],
					search_value: ""
				});
			}
			else {
				let search_value = req.query.bandName;
				// If search field is empty - assign search_value to ""
				if(search_value === null ||
					 search_value === undefined)
				{
					search_value = "";
				}
				// Receive amount of bands that meet criteria
				query = bandModel.count({
					// search (case insensitive) partial match
					name: { "$regex": search_value, "$options": "i" }
				});
				query.exec(function(err, amount) {
					if(err) {
						err = new Error('Sorry, the file with contents were not found on server.');
						err.status = 500;
						next(err);
					}
					else {
						// if amount equals 0, notify the user about it
						if (amount === 0) {
							req.flash('error_msg', 'Nothing was found :(');
							res.redirect('/bands');
						}
						else {
							let pageNumber = req.query.page;
							req.checkQuery('page', 'Page is required').notEmpty();
							if (!search_value) {
								req.checkQuery('page', 'Page should lay in proper bounds (from 1 to ' + parseInt((amount-1)/4 + 1) + ' at the moment).').isInt({ min: 1, max: parseInt((amount-1)/4 + 1) });
							}
							else {
								req.checkQuery('page', 'Page should lay in proper bounds (from 1 to ' + parseInt((amount-1)/4 + 1) + ' for this query).').isInt({ min: 1, max: parseInt((amount-1)/4 + 1) });
							}
							let errs = req.validationErrors();
							// If page is set improperly
							if (errs.length === 1) {
								req.flash('error_msg', errs[0].msg);
								// If the search field was empty: redirect to /bands
								if (!search_value) {
									res.redirect('/bands');
								}
								// If the search field was not empty: redirect to /bands with search field that was set previously
								else {
									res.redirect('/bands?bandName=' + search_value);
								}
							}
							// If page is not set at all: set is on default (1)
							else {
								if (errs.length === 2) {
									pageNumber = 1;
								}
								query = bandModel.find({
									// search (case insensitive) partial match
									name: { "$regex": search_value, "$options": "i" }
								}).limit(4).skip(4 * (pageNumber - 1)).lean();
								query.exec(function(err, bands) {
									if (err) {
										err = new Error('Sorry, the file with contents were not found on server.');
										err.status = 500;
										next(err);
									}
									else {
										res.render('bands', {
									    csrfToken: req.csrfToken(),
											curPage: pageNumber,
											maxPage: parseInt((amount-1)/4 + 1),
											arr: bands,
											search_value: search_value
										});
									}
								});
							}
						}
					}
				});
			}
		});
})

    Вот что бывает, если не разбивать код на модули. Попробуйте разобраться в этих коллбеках, которые в коллбеках, которые в коллбеках, которые...

    tayum, 21 Декабря 2016

    Комментарии (26)